public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org,
	dledford@redhat.com
Subject: Re: [PATCH] Proposed module init race fix.
Date: Fri, 17 Jan 2003 16:35:22 +0100	[thread overview]
Message-ID: <3E2822B9.B4DB7324@linux-m68k.org> (raw)
In-Reply-To: 20030117123827.1abaf413.rusty@rustcorp.com.au

Hi,

(I take it as a good sign that I'm not in your .procmailrc yet. :-) )

Rusty Russell wrote:

> > >         disk->flags |= GENHD_FL_UP;
> > >         blk_register_region(MKDEV(disk->major, disk->first_minor), disk->minors,
> > >                         NULL, exact_match, exact_lock, disk);
> >
> > blk_register_region() allocates memory, which can fail?
> 
> Looks like.  But the semantics are the same as before, for better or worse. 8(

This means add_disk() can fail and according to your rules it can only
be called once. If add_disk() would called a second time, the module
would be live and add_disk() were not allowed to fail anymore.

bye, Roman



  reply	other threads:[~2003-01-17 22:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-15  8:24 [PATCH] Proposed module init race fix Rusty Russell
2003-01-15 16:34 ` Roman Zippel
2003-01-17  1:38   ` Rusty Russell
2003-01-17 15:35     ` Roman Zippel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-01-15  8:46 Adam J. Richter
2003-01-15  9:06 ` Rusty Russell
2003-01-15 14:21 Petr Vandrovec
2003-01-16  1:48 ` Rusty Russell
2003-01-16  2:55   ` Werner Almesberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E2822B9.B4DB7324@linux-m68k.org \
    --to=zippel@linux-m68k.org \
    --cc=dledford@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox