From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C71023371B for ; Sun, 14 Dec 2025 19:35:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765740910; cv=none; b=JtdteZQqs7SmMYh/CB95xJOPwF1fihHNm6+JJtJ/Q4cGfXR2jNF1vxSk+v6LFue85ZUbmrVAihjhbGvq3ZB2aSkpL1GtR3CvPEkt02y1bF/RiKnComBmbdm4djBpFVNJJrrRS0zNldLcvJcvXEti+VY95G5RyW/7Qx7PFUYxA6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765740910; c=relaxed/simple; bh=8YfyG2LFyQSDo1pR1jyRp4tNJOWpVpapq9GRPDoXayc=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=GQBE1P9Y8qcqdYTLPwHUftWaLQ4CtJNeFqOcM4c7PWBIEPFmpszbKvINrgXqiu3J34vomwjDWPOENKFD/UOmmXIOJyz2L3IAVE7xWV87zH9x2EzZ34IWz7xxymOC3mfdeREO2Kae/LNOclDwkuiVZjsj2aATgJPFykDed3AnSmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DUX3RdBn; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZZIL+4T0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DUX3RdBn"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZZIL+4T0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1765740907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H4mZnR7UJNODpWMmXymB0wDsddpATfsL+KraTcKuGLw=; b=DUX3RdBnu3YK4PvNTO5F4pyX8pRQwlYa3FyCqtNRJuyhcYHK7T8AyrJDFbdxeCDbadKiZs Nx6f8cZzE+Gubj8PStv8+6s/4Wp7htz8JPi/RA54X4v4y/gEvRZ6iqsMHgFhF/7G2oc9za nS4WilbagbzMA578xcu6YCqYsu4gyNQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-8-78CPkUIaMxGfzopjqXZm6Q-1; Sun, 14 Dec 2025 14:35:05 -0500 X-MC-Unique: 78CPkUIaMxGfzopjqXZm6Q-1 X-Mimecast-MFC-AGG-ID: 78CPkUIaMxGfzopjqXZm6Q_1765740904 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-430f8866932so391120f8f.1 for ; Sun, 14 Dec 2025 11:35:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1765740904; x=1766345704; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=H4mZnR7UJNODpWMmXymB0wDsddpATfsL+KraTcKuGLw=; b=ZZIL+4T00HM8zWwB0PpthG2EaazKPDgaVABUaVM58w1z8j6POUNtO/irCrYqBp9T1/ 0rtEjc2k2eGXXxZP4RYT1V63YASWhy9Punb94boPQjxbm5nf/uciBN7w89I7+SRWuUVG S3wzC9m3UcfZvjKDX4/l5pY35nWwK+zls42K16Eve4NTzUGInujyXPKkDtIVzned6U3m usPdV2aBXLtqpg87aAoIenM5NwMz3JdN3jBkryr2JcT0JIz3F1ZiYGCz35JmYsyFhPz2 wc34pp3sKSIMC3C0mWG6woB9IyJDEimMTYaW3uAogJq8UT8qKyXLo7iOeoLNUNlN6WyR 54/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765740904; x=1766345704; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H4mZnR7UJNODpWMmXymB0wDsddpATfsL+KraTcKuGLw=; b=jgJYuatgaMqPsR9PvuzpxqDn+OWT6oq2smCLpV7gNIE5MBGK5w3YA82Ijxh8H8/eu3 T6UouW5/SYWWa9ixnEzKWfOBsBrDjYqQ/tt+FuPjURIwbQe8vIHBzOg5+DhcD+QfaMMF a9NYw7HRnYmEyDxy0tV9c+hZ9+Jr7cRNVVNzzHOmsz+Tb5IjR9ltT8SMQxy7ke1SN3xQ 5LxkeUoiZDsa0Gr+TdhkdoZSbqfXg9CfebO2qOUUZtJexFdKMRu4ujALyQrc0UQAlSjx TBqN1AlQjZxovJSwrdyawqqGQJG076b/+4kqtn5/9RVbXUttaGljcF7gzte7W3+ibOdj 1JUA== X-Forwarded-Encrypted: i=1; AJvYcCWk/GVRNpmtxXckRLblZ2i4MouUKiLuAIaqvzECadUr+NVm63w1B2XP7ngusCbXeQWfuyiOr2QMlUL/RwA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2ywDqvgHyB9j57vhkBJ3RhYJh6xzrufiQbfQzdtDCsznVms6D QHKwxvV0kRMgQeATwW9Cf2fQrXtNS82+rsvt2aF84vVuuQ2bfeujUCN1vr5xX4HM3FWfjWioF7v 9hnUrR3bwWwyUtSsBOmVmSHfJQWk/CR2DmyTk1mxL8Kvui1Vq6p379qiPyKzbveYTsw== X-Gm-Gg: AY/fxX5u+s9/o3lKhUZFvLmgovVpuV5r+muPFjyi+gwJKaxDB6crYATrVI1BPUGx6Gd Af3uGwHU33+8nYchUq+vE+Mb9E+KUh9KzRMgAJ7rXsNy/OFgWMDneWQCrovRUTuGzjgCzbut72U 8lGNHCEI4hqqqtaSJgBV3RUYXtv1tuN4CsQfBwvgXE5RsW+Y29ZOeC69P5h/DrhdgDBldQfVWAL rkZUJfM3Aitci0/CZar9okwpx4uhvnA7MI6PLA1Yj5e1flaAE5sKyY55LqCEKdWNMPw31QaI9dS vLCOKtBsM9ukx4US1SkYjyPS/sMJBGmIKOa1lyVFvjl98+MC2M7NmWvKERAhu+2x6zmRClaWZXK +i4qu15IdMnzmOb6K X-Received: by 2002:adf:f28a:0:b0:42f:bbc6:eda2 with SMTP id ffacd0b85a97d-42fbbc6ee74mr6356778f8f.40.1765740903913; Sun, 14 Dec 2025 11:35:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJZygD2dMeXeBlBMcgy1R2+96hGcPhzeLpTRtqAJ2YkZxU6045KWmRjFUtryqBP6cetFCKMQ== X-Received: by 2002:adf:f28a:0:b0:42f:bbc6:eda2 with SMTP id ffacd0b85a97d-42fbbc6ee74mr6356744f8f.40.1765740903457; Sun, 14 Dec 2025 11:35:03 -0800 (PST) Received: from ehlo.thunderbird.net ([2a00:e580:bf11:1:11d6:cade:a15:8421]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8b9b6bfsm24464587f8f.43.2025.12.14.11.35.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Dec 2025 11:35:03 -0800 (PST) Date: Sun, 14 Dec 2025 20:35:01 +0100 From: Ivan Vecera To: Jiri Pirko CC: netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vadim Fedorenko , Arkadiusz Kubalewski , Grzegorz Nitka , Petr Oros , Michal Schmidt , Prathosh Satish , Tony Nguyen , Przemek Kitszel , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch , Richard Cochran , Jonathan Lemon , Simon Horman , Alexander Lobakin , Willem de Bruijn , Stefan Wahren , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_RFC_net-next_02/13=5D_dpll=3A_A?= =?US-ASCII?Q?llow_registering_pin_with_firmware_node?= User-Agent: Thunderbird for Android In-Reply-To: References: <20251211194756.234043-1-ivecera@redhat.com> <20251211194756.234043-3-ivecera@redhat.com> Message-ID: <3E2869EC-61B3-40DA-98E2-CD9543424468@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On December 12, 2025 12:25:12 PM GMT+01:00, Jiri Pirko wrote: >Thu, Dec 11, 2025 at 08:47:45PM +0100, ivecera@redhat=2Ecom wrote: > >[=2E=2E] > >>@@ -559,7 +563,8 @@ EXPORT_SYMBOL(dpll_netdev_pin_clear); >> */ >> struct dpll_pin * >> dpll_pin_get(u64 clock_id, u32 pin_idx, struct module *module, >>- const struct dpll_pin_properties *prop) >>+ const struct dpll_pin_properties *prop, >>+ struct fwnode_handle *fwnode) >> { >> struct dpll_pin *pos, *ret =3D NULL; >> unsigned long i; >>@@ -568,14 +573,15 @@ dpll_pin_get(u64 clock_id, u32 pin_idx, struct mod= ule *module, >> xa_for_each(&dpll_pin_xa, i, pos) { >> if (pos->clock_id =3D=3D clock_id && >> pos->pin_idx =3D=3D pin_idx && >>- pos->module =3D=3D module) { >>+ pos->module =3D=3D module && >>+ pos->fwnode =3D=3D fwnode) { > >Is fwnode part of the key? Doesn't look to me like that=2E Then you can >have a simple helper to set fwnode on struct dpll_pin *, and leave >dpll_pin_get() out of this, no? IMHO yes, because particular fwnode identifies exact dpll pin, so I think it should be a part of the key=2E