Re: [PATCH][2.5] smp_call_function_mask

[Manfred Spraul <manfred@colorfullife.com>]

Zwane Mwaikambo wrote:

>On Tue, 21 Jan 2003, Zwane Mwaikambo wrote:
>
>  
>
>>On Tue, 21 Jan 2003, Manfred Spraul wrote:
>>
>>    
>>
>>>from 2.5.52, <asm-i386/atomic.h>
>>>    #define atomic_read(v)          ((v)->counter)
>>>AFAIK atomic_read never contained locked bus cycles.
>>>
>>>Btw, Zwane, what about removing non_atomic from the prototype?
>>>      
>>>
>>The funny thing is, there are about 3 different versions of 
>>smp_call_function and removing nonatomic would reduce the argument count 
>>    
>>
You can blame me for the mess with smp_call_function:
2.2 supported nonatomic calls. I have no idea if that was deadlock free.

But noone used the 'retry/nonatomic' parameter, noone handled an error 
return of  smp_call_function (some callers panic).
Thus I've removed these features from i386, without changing the 
prototype. I think all archs have picked that up now.
But retry/nonatomic should not spread into new functions.

--
    Manfred