From: "Ulrich Windl" <Ulrich.Windl@rz.uni-regensburg.de>
To: linux-kernel@vger.kernel.org
Subject: 2.4.19: drivers/usb/wacom.c: Intuos tablet broken
Date: Fri, 24 Jan 2003 08:17:44 +0100 [thread overview]
Message-ID: <3E30F658.5317.108EE8@localhost> (raw)
[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 841 bytes --]
Hello,
my apologies if that's old news, but I had reported the effect
that my Intuos GD-1212 that worked with SuSE-8.0 (2.4.18) no
longer worked with SuSE-8.1 (2.4.19). The bug was knows at SuSE
as #22403, but they were unable to provide a solution so far.
Thus I did a diff to the kernel sources. It seems that the
change in drivers/usb/wacom.c from RCS revision .122 to 1.23
(made by vijtech@suse.cz) broke detection of move events in an
obvious way (see lines 241 in 2.4.18 and lines 285 in 2.4.19):
wacom->x and wacom->y are no longer set in 2.4.19!
I'll attach my suggested fix (not tested).
Regards,
Ulrich Windl
P.S. I failed to get any programming info from Wacom, even if
the documentation provided with the tablet said Wacom would
support developers. If anybody here knows a source of
information, please tell me...
[-- Attachment #2: Text from file 'wacom.diff' --]
[-- Type: text/plain, Size: 497 bytes --]
--- wacom.c 2002-08-18 22:11:08.000000000 +0200
+++ wacom.c.new 2003-01-23 19:47:19.000000000 +0100
@@ -288,8 +288,8 @@
x = ((__u32)data[2] << 8) | data[3];
y = ((__u32)data[4] << 8) | data[5];
- input_report_abs(dev, ABS_X, wacom->x);
- input_report_abs(dev, ABS_Y, wacom->y);
+ input_report_abs(dev, ABS_X, wacom->x = x);
+ input_report_abs(dev, ABS_Y, wacom->y = y);
input_report_abs(dev, ABS_DISTANCE, data[9] >> 4);
if ((data[1] & 0xb8) == 0xa0) { /* general pen packet */
reply other threads:[~2003-01-24 7:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E30F658.5317.108EE8@localhost \
--to=ulrich.windl@rz.uni-regensburg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox