public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <p_gortmaker@yahoo.com>
To: Adam Belay <ambx1@neo.rr.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
	Jeff Muizelaar <muizelaar@rogers.com>
Subject: Re: [PATCH] NE PnP Update from Jeff Muizelaar (5/6)
Date: Sun, 26 Jan 2003 04:45:27 -0500	[thread overview]
Message-ID: <3E33AE37.463C9CCF@yahoo.com> (raw)
In-Reply-To: 20030125201528.GA12845@neo.rr.com


I've a couple of quick comments after looking over the patch:

> -"Last modified Nov 1, 2000 by Paul Gortmaker\n";
> +"Last modified January 20, 2003 by Jeff Muizelaar\n";

Feel free to delete this "Last modified" stuff altogether.
It is just extra verbage at boot we don't need. (Blame 
Jeff Garzik -- he put it there, not me...   ;-)

> +               free_irq(dev->irq, dev);
> +               release_region(dev->base_addr, NE_IO_EXTENT);
> +               unregister_netdev(dev);
> +               kfree(dev->priv);
> +               kfree(dev);

It is usually good practice to unregister a device as the 
first thing, and then release its associated resources once
you know the kernel doesn't hold any references to it.

Thanks,
Paul.


  reply	other threads:[~2003-01-26  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-25 20:15 [PATCH] NE PnP Update from Jeff Muizelaar (5/6) Adam Belay
2003-01-26  9:45 ` Paul Gortmaker [this message]
2003-01-26 19:42   ` Jeff Muizelaar
2003-01-26 19:46   ` Jeff Muizelaar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E33AE37.463C9CCF@yahoo.com \
    --to=p_gortmaker@yahoo.com \
    --cc=ambx1@neo.rr.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muizelaar@rogers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox