* Re: Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
@ 2003-01-29 6:29 ` John Kim
2003-01-29 8:03 ` Denis Vlasenko
` (10 subsequent siblings)
11 siblings, 0 replies; 32+ messages in thread
From: John Kim @ 2003-01-29 6:29 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: lkml
Marcelo,
Having CONFIG_DRM40_I810=y causes following compile error:
i810_dma.c: In function `i810_unmap_buffer':
i810_dma.c:234: too many arguments to function `do_munmap'
Following patch fixes that breakage.
John Kim
--- linux-2.4.21-pre4/drivers/char/drm-4.0/i810_dma.c 2003-01-28 23:30:41.000000000 -0500
+++ linux-2.4.21-pre4-new/drivers/char/drm-4.0/i810_dma.c 2003-01-29 01:14:28.000000000 -0500
@@ -231,7 +231,7 @@
#else
retcode = do_munmap(current->mm,
(unsigned long)buf_priv->virtual,
- (size_t) buf->total, 1);
+ (size_t) buf->total);
#endif
up_write(¤t->mm->mmap_sem);
}
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
2003-01-29 6:29 ` John Kim
@ 2003-01-29 8:03 ` Denis Vlasenko
2003-01-29 9:36 ` Alan Cox
2003-01-29 12:49 ` Eyal Lebedinsky
` (9 subsequent siblings)
11 siblings, 1 reply; 32+ messages in thread
From: Denis Vlasenko @ 2003-01-29 8:03 UTC (permalink / raw)
To: Marcelo Tosatti, lkml
On 29 January 2003 05:44, Marcelo Tosatti wrote:
> So here goes -pre4...
>
> Alan Cox <alan@lxorguk.ukuu.org.uk>:
> o allow people to build M686 without PGE kernels
> o more vaio apm blacklist entries
> o mp oops fix
> o MP message improvements
> o remove confusing MP report
> o nmi stack usage
> o fix linux crash on boot with some boarss
> o fix up cx86 docs
> o IPMI driver
> o enable ipmi config
> o fix compile of 4.0 DRM
> o more parisc specific merge bits
> o parisc mux driver (parisc specific)
> o disable taskfile I/O
> o further IDE tape fixes
> o Skip disabled IDE generic controllers
> o Add ide software raid driver for Medley IDE raid
> o add support for Nvidia nForce2 IDE
> o Allow DMA setup on radeon IGP now we think its fixed
> o allow selection of SI raid
> o fix packet padding on 3c501
> o fix packet padding on the 3c505
> o more unusual USB storage devices
> o fix packet padding on the 3c507
> o fix packet padding on the 3c523
> o fix packet padding on the 7990
> o fix packet padding on the 8139too
> o fix 8390 packet padding
> o fix packet padding on at1700
> o fix packet padding on atp
> o fix de600/20 packet padding
> o fix ni5010 packet padding
> o fix ni52 packet padding
> o fix packet padding on ni65
> o fix packet padding on axnet_cs
> o fix padding on sgiseeq
> o fix sk_g16 padding
> o fix sun3_82586 padding
> o fix sun3lance packet padding
> o further dscc4 updates
> o document undocumentend field in SCSI headers
> o fix ad1889 warning - void functions dont return values
> o more unusual USB storage devices
> o ; cut the mount hash table down to a sane size, and fix printk
> o fix casting in pci dma
> o parisc header update
> o fix msdos end markers for compatibility with cameras etc
Alan is unbelievable. 8)
--
vda
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-29 8:03 ` Denis Vlasenko
@ 2003-01-29 9:36 ` Alan Cox
0 siblings, 0 replies; 32+ messages in thread
From: Alan Cox @ 2003-01-29 9:36 UTC (permalink / raw)
To: vda; +Cc: Marcelo Tosatti, lkml
On Wed, 2003-01-29 at 08:03, Denis Vlasenko wrote:
> On 29 January 2003 05:44, Marcelo Tosatti wrote:
> > So here goes -pre4...
> >
> > Alan Cox <alan@lxorguk.ukuu.org.uk>:
> > o allow people to build M686 without PGE kernels
> > o parisc header update
> > o fix msdos end markers for compatibility with cameras etc
>
> Alan is unbelievable. 8)
I sent all those to Marcelo. I didn't write them all. That would be
unbelievable indeed.
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
2003-01-29 6:29 ` John Kim
2003-01-29 8:03 ` Denis Vlasenko
@ 2003-01-29 12:49 ` Eyal Lebedinsky
2003-01-29 13:04 ` Maciej Soltysiak
` (8 subsequent siblings)
11 siblings, 0 replies; 32+ messages in thread
From: Eyal Lebedinsky @ 2003-01-29 12:49 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: lkml
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
Marcelo Tosatti wrote:
>
> Hi,
>
> So here goes -pre4...
I needed these two tiny patches (this is nothing new), and
I got these unresolved:
depmod: *** Unresolved symbols in
/lib/modules/2.4.21-pre4/kernel/drivers/char/ipmi/ipmi_msghandler.o
depmod: panic_notifier_list
depmod: *** Unresolved symbols in
/lib/modules/2.4.21-pre4/kernel/drivers/char/ipmi/ipmi_watchdog.o
depmod: panic_notifier_list
depmod: panic_timeout
.config
=======
CONFIG_IPMI_HANDLER=m
# CONFIG_IPMI_PANIC_EVENT is not set
CONFIG_IPMI_DEVICE_INTERFACE=m
CONFIG_IPMI_KCS=m
CONFIG_IPMI_WATCHDOG=m
--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>
[-- Attachment #2: 2.4.21-pre4-char.patch --]
[-- Type: text/plain, Size: 438 bytes --]
--- linux/drivers/char/Makefile.orig Tue Jan 7 20:13:30 2003
+++ linux/drivers/char/Makefile Tue Jan 7 20:17:16 2003
@@ -24,7 +24,7 @@
export-objs := busmouse.o console.o keyboard.o sysrq.o \
misc.o pty.o random.o selection.o serial.o \
sonypi.o tty_io.o tty_ioctl.o generic_serial.o \
- au1000_gpio.o hp_psaux.o nvram.o
+ au1000_gpio.o hp_psaux.o nvram.o scx200.o
mod-subdirs := joystick ftape drm drm-4.0 pcmcia
[-- Attachment #3: 2.4.21-pre4-sbp2.patch --]
[-- Type: text/plain, Size: 830 bytes --]
--- linux/drivers/ieee1394/sbp2.c.orig Thu Dec 19 10:22:33 2002
+++ linux/drivers/ieee1394/sbp2.c Thu Dec 19 10:23:17 2002
@@ -1511,7 +1511,7 @@
* physical dma in hardware). Mostly just here for debugging...
*/
static int sbp2_handle_physdma_write(struct hpsb_host *host, int nodeid, int destid, quadlet_t *data,
- u64 addr, unsigned int length)
+ u64 addr, unsigned int length, u16 flags)
{
/*
@@ -1527,7 +1527,7 @@
* physical dma in hardware). Mostly just here for debugging...
*/
static int sbp2_handle_physdma_read(struct hpsb_host *host, int nodeid, quadlet_t *data,
- u64 addr, unsigned int length)
+ u64 addr, unsigned int length, u16 flags)
{
/*
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
` (2 preceding siblings ...)
2003-01-29 12:49 ` Eyal Lebedinsky
@ 2003-01-29 13:04 ` Maciej Soltysiak
2003-01-29 21:53 ` Thomas Davis
` (7 subsequent siblings)
11 siblings, 0 replies; 32+ messages in thread
From: Maciej Soltysiak @ 2003-01-29 13:04 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: lkml
> David S. Miller <davem@nuts.ninka.net>:
> o [USB]: rtl8150.c needs linux/init.h
> o [TCP]: Add tcp_low_latency sysctl
Any comments on that? A bit more than is in the sysctl documentation.
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
` (3 preceding siblings ...)
2003-01-29 13:04 ` Maciej Soltysiak
@ 2003-01-29 21:53 ` Thomas Davis
2003-01-30 11:43 ` Alan Cox
2003-01-30 0:47 ` sys_sendfile64 not in " John Fremlin
` (6 subsequent siblings)
11 siblings, 1 reply; 32+ messages in thread
From: Thomas Davis @ 2003-01-29 21:53 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: lkml
[-- Attachment #1: Type: text/plain, Size: 105 bytes --]
This simple one line patch adds the missing ac97 support that the fm801
driver already uses.
thomas
[-- Attachment #2: forte_ac97_codec.diff --]
[-- Type: text/plain, Size: 589 bytes --]
--- linux-2.4.21-pre2/drivers/sound/ac97_codec.c Tue Dec 24 15:37:53 2002
+++ linux-2.4.20-ac1/drivers/sound/ac97_codec.c Fri Dec 6 00:07:04 2002
@@ -133,6 +133,7 @@
{0x43525931, "Cirrus Logic CS4299 rev A", &crystal_digital_ops},
{0x43525933, "Cirrus Logic CS4299 rev C", &crystal_digital_ops},
{0x43525934, "Cirrus Logic CS4299 rev D", &crystal_digital_ops},
+ {0x44543031, "Forte Media FM801", &null_ops},
{0x45838308, "ESS Allegro ES1988", &null_ops},
{0x49434511, "ICE1232", &null_ops}, /* I hope --jk */
{0x4e534331, "National Semiconductor LM4549", &null_ops},
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-29 21:53 ` Thomas Davis
@ 2003-01-30 11:43 ` Alan Cox
2003-01-30 17:09 ` Thomas Davis
0 siblings, 1 reply; 32+ messages in thread
From: Alan Cox @ 2003-01-30 11:43 UTC (permalink / raw)
To: Thomas Davis; +Cc: Marcelo Tosatti, lkml
On Wed, 2003-01-29 at 21:53, Thomas Davis wrote:
> This simple one line patch adds the missing ac97 support that the fm801
> driver already uses.
FM801 is a card not a codec
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: Linux 2.4.21-pre4
2003-01-30 11:43 ` Alan Cox
@ 2003-01-30 17:09 ` Thomas Davis
2003-01-30 18:17 ` Alan Cox
0 siblings, 1 reply; 32+ messages in thread
From: Thomas Davis @ 2003-01-30 17:09 UTC (permalink / raw)
To: Alan Cox; +Cc: Marcelo Tosatti, lkml
Alan Cox wrote:
> On Wed, 2003-01-29 at 21:53, Thomas Davis wrote:
>
>>This simple one line patch adds the missing ac97 support that the fm801
>>driver already uses.
>
>
> FM801 is a card not a codec
>
Sorry, this then adds to the ac97 codec list the fm801, which has a ac97
codec on it, and takes it from being "unknown" to "known".
The forte driver uses the ac97codec code; with this, ac97_probe_codec
registers it correctly as Forte Media, and not unknown.
No, it doesn't change the codec_ops - it just gets codec->name correct.
Yea, it is comestic, but some mixers didn't like it having a name of
"Unknown".
Better?
thomas
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: Linux 2.4.21-pre4
2003-01-30 17:09 ` Thomas Davis
@ 2003-01-30 18:17 ` Alan Cox
2003-01-30 17:26 ` Thomas Davis
0 siblings, 1 reply; 32+ messages in thread
From: Alan Cox @ 2003-01-30 18:17 UTC (permalink / raw)
To: Thomas Davis; +Cc: Marcelo Tosatti, lkml
On Thu, 2003-01-30 at 17:09, Thomas Davis wrote:
> > FM801 is a card not a codec
> >
>
> Sorry, this then adds to the ac97 codec list the fm801, which has a ac97
> codec on it, and takes it from being "unknown" to "known".
>
> The forte driver uses the ac97codec code; with this, ac97_probe_codec
> registers it correctly as Forte Media, and not unknown.
FM801 is still the card not the codec. Somewhere on the FM801 is a 48pin AC97 codec,
it may even vary by card version, much like I have intel i810 audio with a variety
of codec devices.
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: Linux 2.4.21-pre4
2003-01-30 18:17 ` Alan Cox
@ 2003-01-30 17:26 ` Thomas Davis
2003-01-30 18:28 ` Alan Cox
0 siblings, 1 reply; 32+ messages in thread
From: Thomas Davis @ 2003-01-30 17:26 UTC (permalink / raw)
To: Alan Cox; +Cc: Marcelo Tosatti, lkml
Alan Cox wrote:
> On Thu, 2003-01-30 at 17:09, Thomas Davis wrote:
>
>>>FM801 is a card not a codec
>>>
>>
>>Sorry, this then adds to the ac97 codec list the fm801, which has a ac97
>>codec on it, and takes it from being "unknown" to "known".
>>
>>The forte driver uses the ac97codec code; with this, ac97_probe_codec
>>registers it correctly as Forte Media, and not unknown.
>
>
> FM801 is still the card not the codec. Somewhere on the FM801 is a 48pin AC97 codec,
> it may even vary by card version, much like I have intel i810 audio with a variety
> of codec devices.
>
Yes, I agree on that.. I'm just trying to get the name "Forte Media
FM801" instead of "Unknown" to show up in the ac97 list.
thomas
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: Linux 2.4.21-pre4
2003-01-30 17:26 ` Thomas Davis
@ 2003-01-30 18:28 ` Alan Cox
0 siblings, 0 replies; 32+ messages in thread
From: Alan Cox @ 2003-01-30 18:28 UTC (permalink / raw)
To: Thomas Davis; +Cc: Marcelo Tosatti, lkml
On Thu, 2003-01-30 at 17:26, Thomas Davis wrote:
> > FM801 is still the card not the codec. Somewhere on the FM801 is a 48pin AC97 codec,
> > it may even vary by card version, much like I have intel i810 audio with a variety
> > of codec devices.
> >
>
> Yes, I agree on that.. I'm just trying to get the name "Forte Media
> FM801" instead of "Unknown" to show up in the ac97 list.
Why ? How do you even know the codec is made by forte media ?
^ permalink raw reply [flat|nested] 32+ messages in thread
* sys_sendfile64 not in Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
` (4 preceding siblings ...)
2003-01-29 21:53 ` Thomas Davis
@ 2003-01-30 0:47 ` John Fremlin
2003-01-30 8:29 ` Christoph Hellwig
2003-01-30 17:53 ` Thomas Davis
` (5 subsequent siblings)
11 siblings, 1 reply; 32+ messages in thread
From: John Fremlin @ 2003-01-30 0:47 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: lkml, cw, bcrl
Why isn't sendfile64 included in 2.4.21-pre4? glibc 2.3 already
expects it, so programs with 64-bit off_t will not be able to use
sendfile otherwise. And the patch is IIUC very small . . .
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: sys_sendfile64 not in Linux 2.4.21-pre4
2003-01-30 0:47 ` sys_sendfile64 not in " John Fremlin
@ 2003-01-30 8:29 ` Christoph Hellwig
2003-01-30 11:33 ` Alan Cox
0 siblings, 1 reply; 32+ messages in thread
From: Christoph Hellwig @ 2003-01-30 8:29 UTC (permalink / raw)
To: John Fremlin; +Cc: Marcelo Tosatti, lkml, cw, bcrl
On Thu, Jan 30, 2003 at 12:47:14AM +0000, John Fremlin wrote:
>
> Why isn't sendfile64 included in 2.4.21-pre4? glibc 2.3 already
> expects it, so programs with 64-bit off_t will not be able to use
> sendfile otherwise. And the patch is IIUC very small . . .
I sent patches to Marcelo a few times, but they got silently ignored..
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: sys_sendfile64 not in Linux 2.4.21-pre4
2003-01-30 8:29 ` Christoph Hellwig
@ 2003-01-30 11:33 ` Alan Cox
2003-01-30 11:02 ` Marc-Christian Petersen
0 siblings, 1 reply; 32+ messages in thread
From: Alan Cox @ 2003-01-30 11:33 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: John Fremlin, Marcelo Tosatti, lkml, cw, bcrl
On Thu, 2003-01-30 at 08:29, Christoph Hellwig wrote:
> On Thu, Jan 30, 2003 at 12:47:14AM +0000, John Fremlin wrote:
> >
> > Why isn't sendfile64 included in 2.4.21-pre4? glibc 2.3 already
> > expects it, so programs with 64-bit off_t will not be able to use
> > sendfile otherwise. And the patch is IIUC very small . . .
>
> I sent patches to Marcelo a few times, but they got silently ignored..
Can you forward me a copy ?
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: sys_sendfile64 not in Linux 2.4.21-pre4
2003-01-30 11:33 ` Alan Cox
@ 2003-01-30 11:02 ` Marc-Christian Petersen
2003-01-30 11:16 ` Christoph Hellwig
0 siblings, 1 reply; 32+ messages in thread
From: Marc-Christian Petersen @ 2003-01-30 11:02 UTC (permalink / raw)
To: Alan Cox, Christoph Hellwig; +Cc: John Fremlin, Marcelo Tosatti, lkml, cw, bcrl
On Thursday 30 January 2003 12:33, Alan Cox wrote:
> On Thu, 2003-01-30 at 08:29, Christoph Hellwig wrote:
> > On Thu, Jan 30, 2003 at 12:47:14AM +0000, John Fremlin wrote:
> > > Why isn't sendfile64 included in 2.4.21-pre4? glibc 2.3 already
> > > expects it, so programs with 64-bit off_t will not be able to use
> > > sendfile otherwise. And the patch is IIUC very small . . .
> >
> > I sent patches to Marcelo a few times, but they got silently ignored..
>
> Can you forward me a copy ?
to me too please :)
ciao, Marc
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: sys_sendfile64 not in Linux 2.4.21-pre4
2003-01-30 11:02 ` Marc-Christian Petersen
@ 2003-01-30 11:16 ` Christoph Hellwig
0 siblings, 0 replies; 32+ messages in thread
From: Christoph Hellwig @ 2003-01-30 11:16 UTC (permalink / raw)
To: Marc-Christian Petersen
Cc: Alan Cox, John Fremlin, Marcelo Tosatti, lkml, cw, bcrl
On Thu, Jan 30, 2003 at 12:02:01PM +0100, Marc-Christian Petersen wrote:
> > > > Why isn't sendfile64 included in 2.4.21-pre4? glibc 2.3 already
> > > > expects it, so programs with 64-bit off_t will not be able to use
> > > > sendfile otherwise. And the patch is IIUC very small . . .
> > >
> > > I sent patches to Marcelo a few times, but they got silently ignored..
> >
> > Can you forward me a copy ?
> to me too please :)
--- linux-2.4.18/arch/i386/kernel/entry.S~ Sun Jun 9 13:39:14 2002
+++ linux-2.4.18/arch/i386/kernel/entry.S Sun Jun 9 13:44:45 2002
@@ -645,7 +645,7 @@
.long SYMBOL_NAME(sys_ni_syscall) /* reserved for lremovexattr */
.long SYMBOL_NAME(sys_ni_syscall) /* reserved for fremovexattr */
.long SYMBOL_NAME(sys_tkill)
- .long SYMBOL_NAME(sys_ni_syscall) /* reserved for sendfile64 */
+ .long SYMBOL_NAME(sys_sendfile64)
.long SYMBOL_NAME(sys_ni_syscall) /* 240 reserved for futex */
.long SYMBOL_NAME(sys_ni_syscall) /* reserved for sched_setaffinity */
.long SYMBOL_NAME(sys_ni_syscall) /* reserved for sched_getaffinity */
--- linux-2.4.18/mm/filemap.c~ Sun Jun 9 13:39:21 2002
+++ linux-2.4.18/mm/filemap.c Sun Jun 9 13:48:38 2002
@@ -1889,7 +1889,7 @@
return written;
}
-asmlinkage ssize_t sys_sendfile(int out_fd, int in_fd, off_t *offset, size_t count)
+static ssize_t common_sendfile(int out_fd, int in_fd, loff_t *offset, size_t count)
{
ssize_t retval;
struct file * in_file, * out_file;
@@ -1934,27 +1934,19 @@
retval = 0;
if (count) {
read_descriptor_t desc;
- loff_t pos = 0, *ppos;
-
- retval = -EFAULT;
- ppos = &in_file->f_pos;
- if (offset) {
- if (get_user(pos, offset))
- goto fput_out;
- ppos = &pos;
- }
+
+ if (!offset)
+ offset = &in_file->f_pos;
desc.written = 0;
desc.count = count;
desc.buf = (char *) out_file;
desc.error = 0;
- do_generic_file_read(in_file, ppos, &desc, file_send_actor);
+ do_generic_file_read(in_file, offset, &desc, file_send_actor);
retval = desc.written;
if (!retval)
retval = desc.error;
- if (offset)
- put_user(pos, offset);
}
fput_out:
@@ -1965,6 +1957,42 @@
return retval;
}
+asmlinkage ssize_t sys_sendfile(int out_fd, int in_fd, off_t *offset, size_t count)
+{
+ loff_t pos, *ppos = NULL;
+ ssize_t ret;
+
+ if (offset) {
+ off_t off;
+ if (unlikely(get_user(off, offset)))
+ return -EFAULT;
+ pos = off;
+ ppos = &pos;
+ }
+
+ ret = common_sendfile(out_fd, in_fd, ppos, count);
+ if (offset)
+ put_user((off_t)pos, offset);
+ return ret;
+}
+
+asmlinkage ssize_t sys_sendfile64(int out_fd, int in_fd, loff_t *offset, size_t count)
+{
+ loff_t pos, *ppos = NULL;
+ ssize_t ret;
+
+ if (offset) {
+ if (unlikely(copy_from_user(&pos, offset, sizeof(loff_t))))
+ return -EFAULT;
+ ppos = &pos;
+ }
+
+ ret = common_sendfile(out_fd, in_fd, ppos, count);
+ if (offset)
+ put_user(pos, offset);
+ return ret;
+}
+
static ssize_t do_readahead(struct file *file, unsigned long index, unsigned long nr)
{
struct address_space *mapping = file->f_dentry->d_inode->i_mapping;
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
` (5 preceding siblings ...)
2003-01-30 0:47 ` sys_sendfile64 not in " John Fremlin
@ 2003-01-30 17:53 ` Thomas Davis
2003-01-30 19:35 ` Alan Cox
2003-01-30 18:46 ` Thomas Davis
` (4 subsequent siblings)
11 siblings, 1 reply; 32+ messages in thread
From: Thomas Davis @ 2003-01-30 17:53 UTC (permalink / raw)
To: Alan Cox; +Cc: Marcelo Tosatti, lkml
Alan Cox wrote:
> On Thu, 2003-01-30 at 17:26, Thomas Davis wrote:
>
> >>FM801 is still the card not the codec. Somewhere on the FM801 is a
> 48pin AC97 codec,
> >>it may even vary by card version, much like I have intel i810 audio
> with a variety
> >>of codec devices.
> >>
> >
> >Yes, I agree on that.. I'm just trying to get the name "Forte Media
> >FM801" instead of "Unknown" to show up in the ac97 list.
>
>
> Why ? How do you even know the codec is made by forte media ?
>
because the forte driver does this:
[tdavis@lanshark sound]$ grep ac97 forte.c
#include <linux/ac97_codec.h>
spinlock_t ac97_lock;
struct ac97_codec *ac97;
* forte_ac97_wait:
forte_ac97_wait (struct forte_chip *chip)
* forte_ac97_read:
forte_ac97_read (struct ac97_codec *codec, u8 reg)
spin_lock (&chip->ac97_lock);
if (forte_ac97_wait (chip)) {
printk (KERN_ERR PFX "ac97_read: Serial bus busy\n");
if (forte_ac97_wait (chip)) {
printk (KERN_ERR PFX "ac97_read: Bus busy reading reg
0x%x\n",
printk (KERN_ERR PFX "ac97_read: Invalid data port");
spin_unlock (&chip->ac97_lock);
* forte_ac97_write:
forte_ac97_write (struct ac97_codec *codec, u8 reg, u16 val)
spin_lock (&chip->ac97_lock);
if (forte_ac97_wait (chip)) {
printk (KERN_ERR PFX "ac97_write: Serial bus busy\n");
if (forte_ac97_wait (chip)) {
printk (KERN_ERR PFX "ac97_write: Bus busy after write\n");
spin_unlock (&chip->ac97_lock);
file->private_data = chip->ac97;
struct ac97_codec *codec = (struct ac97_codec *)
file->private_data;
if (!create_proc_read_entry("driver/forte/ac97", 0, 0,
ac97_read_proc, forte->ac97)) {
remove_proc_entry ("driver/forte/ac97", NULL);
struct ac97_codec *codec;
if ((codec = kmalloc (sizeof (struct ac97_codec), GFP_KERNEL))
== NULL)
memset (codec, 0, sizeof (struct ac97_codec));
codec->codec_read = forte_ac97_read;
codec->codec_write = forte_ac97_write;
if (ac97_probe_codec (codec) == 0) {
chip->ac97 = codec;
spin_lock_init (&chip->ac97_lock);
unregister_sound_mixer (chip->ac97->dev_mixer);
ie, it has a ac97 support in the driver, it calls ac97_probe_codec?
Is that enough or not?
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-30 17:53 ` Thomas Davis
@ 2003-01-30 19:35 ` Alan Cox
0 siblings, 0 replies; 32+ messages in thread
From: Alan Cox @ 2003-01-30 19:35 UTC (permalink / raw)
To: Thomas Davis; +Cc: Marcelo Tosatti, lkml
On Thu, 2003-01-30 at 17:53, Thomas Davis wrote:
>
> ie, it has a ac97 support in the driver, it calls ac97_probe_codec?
>
> Is that enough or not?
The codec and the sound card are two seperate things. The FM801
hardware has an AC97 digital interface that talks to a codec chip
of which there are a considerable number. Which one depends on
who made the specific board you have. The ac97 side isnt part
of the FM801 any more than a PC motherboard automatically
has an Intel CPU
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
` (6 preceding siblings ...)
2003-01-30 17:53 ` Thomas Davis
@ 2003-01-30 18:46 ` Thomas Davis
2003-01-30 23:13 ` Martin K. Petersen
2003-01-30 23:30 ` Thomas Davis
` (3 subsequent siblings)
11 siblings, 1 reply; 32+ messages in thread
From: Thomas Davis @ 2003-01-30 18:46 UTC (permalink / raw)
To: Alan Cox; +Cc: Marcelo Tosatti, lkml
Alan Cox wrote:
> On Thu, 2003-01-30 at 17:53, Thomas Davis wrote:
>
> >ie, it has a ac97 support in the driver, it calls ac97_probe_codec?
> >
> >Is that enough or not?
>
>
> The codec and the sound card are two seperate things. The FM801
> hardware has an AC97 digital interface that talks to a codec chip
> of which there are a considerable number. Which one depends on
> who made the specific board you have. The ac97 side isnt part
> of the FM801 any more than a PC motherboard automatically
> has an Intel CPU
>
Ok, fine.
How do I get the name in there other than "Unknown"?
It's a single chip card.
Thanks.
thomas
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-30 18:46 ` Thomas Davis
@ 2003-01-30 23:13 ` Martin K. Petersen
2003-01-31 3:14 ` Thomas Davis
0 siblings, 1 reply; 32+ messages in thread
From: Martin K. Petersen @ 2003-01-30 23:13 UTC (permalink / raw)
To: Thomas Davis; +Cc: Alan Cox, Marcelo Tosatti, lkml
>>>>> "Thomas" == Thomas Davis <tadavis@lbl.gov> writes:
Thomas,
Alan is right. I have yet to see an FM801 with the AC97 codec
on the chip.
Thomas> How do I get the name in there other than "Unknown"?
Thomas> It's a single chip card.
What kind of card is it? Are you sure there isn't a tiny codec chip
hiding somewhere?
--
Martin K. Petersen http://mkp.net/
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: Linux 2.4.21-pre4
2003-01-30 23:13 ` Martin K. Petersen
@ 2003-01-31 3:14 ` Thomas Davis
2003-01-31 4:09 ` Martin K. Petersen
0 siblings, 1 reply; 32+ messages in thread
From: Thomas Davis @ 2003-01-31 3:14 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: Alan Cox, Marcelo Tosatti, lkml
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
Martin K. Petersen wrote:
>>>>>>"Thomas" == Thomas Davis <tadavis@lbl.gov> writes:
>
>
> Thomas,
>
> Alan is right. I have yet to see an FM801 with the AC97 codec
> on the chip.
>
> Thomas> How do I get the name in there other than "Unknown"?
>
> Thomas> It's a single chip card.
>
> What kind of card is it? Are you sure there isn't a tiny codec chip
> hiding somewhere?
>
The card has 3 chips on it
1 - TEA2025 audio stereo amp
2 - DT9011 - ??
3 - DT0389
So, it is ok to make it "Diamond Technology DT0389"?
See attached patch.
[-- Attachment #2: forte_ac97_codec --]
[-- Type: text/plain, Size: 597 bytes --]
--- linux-2.4.21-pre2/drivers/sound/ac97_codec.c Tue Dec 24 15:37:53 2002
+++ linux-2.4.20-ac1/drivers/sound/ac97_codec.c Fri Dec 6 00:07:04 2002
@@ -133,6 +133,7 @@
{0x43525931, "Cirrus Logic CS4299 rev A", &crystal_digital_ops},
{0x43525933, "Cirrus Logic CS4299 rev C", &crystal_digital_ops},
{0x43525934, "Cirrus Logic CS4299 rev D", &crystal_digital_ops},
+ {0x44543031, "Diamond Technology DT0398", &null_ops},
{0x45838308, "ESS Allegro ES1988", &null_ops},
{0x49434511, "ICE1232", &null_ops}, /* I hope --jk */
{0x4e534331, "National Semiconductor LM4549", &null_ops},
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-31 3:14 ` Thomas Davis
@ 2003-01-31 4:09 ` Martin K. Petersen
2003-01-31 4:13 ` Thomas Davis
0 siblings, 1 reply; 32+ messages in thread
From: Martin K. Petersen @ 2003-01-31 4:09 UTC (permalink / raw)
To: Thomas Davis; +Cc: Alan Cox, Marcelo Tosatti, lkml
>>>>> "Thomas" == Thomas Davis <tadavis@lbl.gov> writes:
>> What kind of card is it? Are you sure there isn't a tiny codec
>> chip hiding somewhere?
Thomas> The card has 3 chips on it
Thomas> 1 - TEA2025 audio stereo amp 2 - DT9011 - ?? 3 - DT0389
Thomas> So, it is ok to make it "Diamond Technology DT0389"?
Your card looks like this, right?
http://www.mkp.net/dt0398.jpg
What does it say on the codec chip? Is that the DT9011?
--
Martin K. Petersen Wild Open Source, Inc.
mkp@wildopensource.com http://www.wildopensource.com/
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-31 4:09 ` Martin K. Petersen
@ 2003-01-31 4:13 ` Thomas Davis
2003-01-31 4:31 ` Martin K. Petersen
0 siblings, 1 reply; 32+ messages in thread
From: Thomas Davis @ 2003-01-31 4:13 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: Alan Cox, Marcelo Tosatti, lkml
Martin K. Petersen wrote:
>>>>>>"Thomas" == Thomas Davis <tadavis@lbl.gov> writes:
>
>
>>>What kind of card is it? Are you sure there isn't a tiny codec
>>>chip hiding somewhere?
>
>
> Thomas> The card has 3 chips on it
>
> Thomas> 1 - TEA2025 audio stereo amp 2 - DT9011 - ?? 3 - DT0389
>
> Thomas> So, it is ok to make it "Diamond Technology DT0389"?
>
> Your card looks like this, right?
>
> http://www.mkp.net/dt0398.jpg
>
> What does it say on the codec chip? Is that the DT9011?
>
yup, in itty bitty print.
I can find references to the dt0389, but not to the dt9011.
t
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: Linux 2.4.21-pre4
2003-01-31 4:13 ` Thomas Davis
@ 2003-01-31 4:31 ` Martin K. Petersen
2003-01-31 4:48 ` Thomas Davis
2003-01-31 6:16 ` Thomas Davis
0 siblings, 2 replies; 32+ messages in thread
From: Martin K. Petersen @ 2003-01-31 4:31 UTC (permalink / raw)
To: Thomas Davis; +Cc: Alan Cox, Marcelo Tosatti, lkml
>>>>> "Thomas" == Thomas Davis <tadavis@lbl.gov> writes:
>> What does it say on the codec chip? Is that the DT9011?
Thomas> yup, in itty bitty print.
In that case I'd suggest the following:
--- linux-2.4.21-pre2/drivers/sound/ac97_codec.c Tue Dec 24 15:37:53 2002
+++ linux-2.4.20-ac1/drivers/sound/ac97_codec.c Fri Dec 6 00:07:04 2002
@@ -133,6 +133,7 @@
{0x43525931, "Cirrus Logic CS4299 rev A", &crystal_digital_ops},
{0x43525933, "Cirrus Logic CS4299 rev C", &crystal_digital_ops},
{0x43525934, "Cirrus Logic CS4299 rev D", &crystal_digital_ops},
+ {0x44543031, "Diamond Technologies DT9011", &null_ops},
{0x45838308, "ESS Allegro ES1988", &null_ops},
{0x49434511, "ICE1232", &null_ops}, /* I hope --jk */
{0x4e534331, "National Semiconductor LM4549", &null_ops},
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-31 4:31 ` Martin K. Petersen
@ 2003-01-31 4:48 ` Thomas Davis
2003-01-31 6:16 ` Thomas Davis
1 sibling, 0 replies; 32+ messages in thread
From: Thomas Davis @ 2003-01-31 4:48 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: Alan Cox, Marcelo Tosatti, lkml
The problem I have with that, is no one knows what that is.
I do understand why you want that - in case there's another card that uses it.
The DT0893 at least means something - it's in big print on it.
thomas
Martin K. Petersen wrote:
>>>>>>"Thomas" == Thomas Davis <tadavis@lbl.gov> writes:
>
>
>>>What does it say on the codec chip? Is that the DT9011?
>
>
> Thomas> yup, in itty bitty print.
>
> In that case I'd suggest the following:
>
> --- linux-2.4.21-pre2/drivers/sound/ac97_codec.c Tue Dec 24 15:37:53 2002
> +++ linux-2.4.20-ac1/drivers/sound/ac97_codec.c Fri Dec 6 00:07:04 2002
> @@ -133,6 +133,7 @@
> {0x43525931, "Cirrus Logic CS4299 rev A", &crystal_digital_ops},
> {0x43525933, "Cirrus Logic CS4299 rev C", &crystal_digital_ops},
> {0x43525934, "Cirrus Logic CS4299 rev D", &crystal_digital_ops},
> + {0x44543031, "Diamond Technologies DT9011", &null_ops},
> {0x45838308, "ESS Allegro ES1988", &null_ops},
> {0x49434511, "ICE1232", &null_ops}, /* I hope --jk */
> {0x4e534331, "National Semiconductor LM4549", &null_ops},
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-31 4:31 ` Martin K. Petersen
2003-01-31 4:48 ` Thomas Davis
@ 2003-01-31 6:16 ` Thomas Davis
1 sibling, 0 replies; 32+ messages in thread
From: Thomas Davis @ 2003-01-31 6:16 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: Alan Cox, Marcelo Tosatti, lkml
hmm.. how about - DT9011 doesn't mean crap to any one.. DT0893 is printed in big clear letters on it.
this is what things like kmix (from kde) uses to indicate sound card.
so put both on it.
thomas
Martin K. Petersen wrote:
>>>>>>"Thomas" == Thomas Davis <tadavis@lbl.gov> writes:
>
>
>>>What does it say on the codec chip? Is that the DT9011?
>
>
> Thomas> yup, in itty bitty print.
>
> In that case I'd suggest the following:
>
--- linux-2.4.21-pre2/drivers/sound/ac97_codec.c Tue Dec 24 15:37:53 2002
+++ linux-2.4.20-ac1/drivers/sound/ac97_codec.c Fri Dec 6 00:07:04 2002
@@ -133,6 +133,7 @@
{0x43525931, "Cirrus Logic CS4299 rev A", &crystal_digital_ops},
{0x43525933, "Cirrus Logic CS4299 rev C", &crystal_digital_ops},
{0x43525934, "Cirrus Logic CS4299 rev D", &crystal_digital_ops},
+ {0x44543031, "Diamond Technologies DT0893/DT9011", &null_ops},
{0x45838308, "ESS Allegro ES1988", &null_ops},
{0x49434511, "ICE1232", &null_ops}, /* I hope --jk */
{0x4e534331, "National Semiconductor LM4549", &null_ops},
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
` (7 preceding siblings ...)
2003-01-30 18:46 ` Thomas Davis
@ 2003-01-30 23:30 ` Thomas Davis
2003-02-01 23:24 ` Adrian Bunk
` (2 subsequent siblings)
11 siblings, 0 replies; 32+ messages in thread
From: Thomas Davis @ 2003-01-30 23:30 UTC (permalink / raw)
To: Martin K. Petersen; +Cc: Alan Cox, Marcelo Tosatti, lkml
Martin K. Petersen wrote:
> >>>>>"Thomas" == Thomas Davis writes:
>
>
> Thomas,
>
> Alan is right. I have yet to see an FM801 with the AC97 codec
> on the chip.
>
> Thomas> How do I get the name in there other than "Unknown"?
>
> Thomas> It's a single chip card.
>
> What kind of card is it? Are you sure there isn't a tiny codec chip
> hiding somewhere?
>
We will find out in a few hours - it's at home, not here at work.
thomas
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
` (8 preceding siblings ...)
2003-01-30 23:30 ` Thomas Davis
@ 2003-02-01 23:24 ` Adrian Bunk
2003-02-02 11:06 ` Adrian Bunk
2003-02-10 16:08 ` Jörn Engel
11 siblings, 0 replies; 32+ messages in thread
From: Adrian Bunk @ 2003-02-01 23:24 UTC (permalink / raw)
To: Marcelo Tosatti, Alan Cox; +Cc: lkml
I get the following compile error in 2.4.21-pre4:
<-- snip -->
...
ld -m elf_i386 -r -o idedriver-raid.o ataraid.o pdcraid.o hptraid.o
silraid.o
silraid.o(.text+0x31c): In function `partition_map_normal':
: multiple definition of `partition_map_normal'
pdcraid.o(.text+0x31c): first defined here
make[4]: *** [idedriver-raid.o] Error 1
make[4]: Leaving directory
`/home/bunk/linux/kernel-2.4/linux-2.4.20-full/drivers/ide/raid'
<-- snip -->
The following patch (stolen from -ac) fixes it:
--- linux.21pre4/drivers/ide/raid/silraid.c 2003-01-29 17:07:45.000000000 +0000
+++ linux.21pre4-ac1/drivers/ide/raid/silraid.c 2003-01-09 19:43:30.000000000 +0000
@@ -157,7 +157,7 @@
}
-unsigned long partition_map_normal(unsigned long block, unsigned long partition_off, unsigned long partition_size, int stride)
+static unsigned long partition_map_normal(unsigned long block, unsigned long partition_off, unsigned long partition_size, int stride)
{
return block + partition_off;
}
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
` (9 preceding siblings ...)
2003-02-01 23:24 ` Adrian Bunk
@ 2003-02-02 11:06 ` Adrian Bunk
2003-02-02 13:38 ` Alan Cox
2003-02-10 16:08 ` Jörn Engel
11 siblings, 1 reply; 32+ messages in thread
From: Adrian Bunk @ 2003-02-02 11:06 UTC (permalink / raw)
To: Marcelo Tosatti, Alan Cox; +Cc: lkml
On Wed, Jan 29, 2003 at 01:44:49AM -0200, Marcelo Tosatti wrote:
>...
> Summary of changes from v2.4.21-pre3 to v2.4.21-pre4
> ============================================
>...
> Alan Cox <alan@lxorguk.ukuu.org.uk>:
>...
> o fix packet padding on the 3c523
>...
This causes the following compile error:
<-- snip -->
...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.20-full/include
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6 -nostdinc
-iwithprefix include -DKBUILD_BASENAME=3c523 -c -o 3c523.o 3c523.c
3c523.c:1128: macro `memset' used with just one arg
3c523.c: In function `elmc_send_packet':
3c523.c:1128: parse error before `)'
3c523.c:1128: structure has no member named `xmit'
3c523.c:1128: parse error before `)'
3c523.c:1128: parse error before `)'
3c523.c:1128: parse error before `)'
3c523.c:1128: warning: left-hand operand of comma expression has no effect
3c523.c:1128: warning: left-hand operand of comma expression has no effect
3c523.c:1128: parse error before `:'
make[3]: *** [3c523.o] Error 1
make[3]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.20-full/drivers/net'
<-- snip -->
The simple fix (stolen from -ac) is:
--- linux.21pre4/drivers/net/3c523.c 2003-01-29 17:07:45.000000000 +0000
+++ linux.21pre4-ac1/drivers/net/3c523.c 2003-01-09 00:47:04.000000000 +0000
@@ -1125,7 +1125,7 @@
len = (ETH_ZLEN < skb->len) ? skb->len : ETH_ZLEN;
if(len != skb->len)
- memset((char *) p->xmit_cbuffs[p->xmit)count], 0, ETH_ZLEN);
+ memset((char *) p->xmit_cbuffs[p->xmit_count], 0, ETH_ZLEN);
memcpy((char *) p->xmit_cbuffs[p->xmit_count], (char *) (skb->data), skb->len);
#if (NUM_XMIT_BUFFS == 1)
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: Linux 2.4.21-pre4
2003-02-02 11:06 ` Adrian Bunk
@ 2003-02-02 13:38 ` Alan Cox
0 siblings, 0 replies; 32+ messages in thread
From: Alan Cox @ 2003-02-02 13:38 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Marcelo Tosatti, lkml
On Sun, 2003-02-02 at 11:06, Adrian Bunk wrote:
> On Wed, Jan 29, 2003 at 01:44:49AM -0200, Marcelo Tosatti wrote:
>
> >...
> > Summary of changes from v2.4.21-pre3 to v2.4.21-pre4
> > ============================================
> >...
> > Alan Cox <alan@lxorguk.ukuu.org.uk>:
> >...
> > o fix packet padding on the 3c523
> >...
>
> This causes the following compile error:
Fix already sent to Marcelo
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: Linux 2.4.21-pre4
2003-01-29 3:44 Linux 2.4.21-pre4 Marcelo Tosatti
` (10 preceding siblings ...)
2003-02-02 11:06 ` Adrian Bunk
@ 2003-02-10 16:08 ` Jörn Engel
11 siblings, 0 replies; 32+ messages in thread
From: Jörn Engel @ 2003-02-10 16:08 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: lkml
Hi!
I got the following compile error on i386. Config is rather long.
http://wh.fh-wedel.de/~joern/.config
make[1]: Entering directory `/home/joern/i386/linux-2.4.21-pre4/kernel'
make all_targets
make[2]: Entering directory `/home/joern/i386/linux-2.4.21-pre4/kernel'
gcc -D__KERNEL__ -I/home/joern/i386/linux-2.4.21-pre4/include -Wall -Wstrict-pro
totypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe -mpreferred-st
ack-boundary=2 -march=i686 -nostdinc -iwithprefix include -DKBUILD_BASENAME=sc
hed -fno-omit-frame-pointer -c -o sched.o sched.c
beam_compile -DKBUILD_BASENAME=sched -fno-omit-frame-pointer -c sched.c
In file included from /usr/include/linux/timex.h:152,
from /usr/include/linux/sched.h:14,
from /usr/include/linux/mm.h:4,
from sched.c:23:
/usr/include/asm/timex.h:10:21: asm/msr.h: No such file or directory
In file included from /usr/include/linux/sched.h:14,
from /usr/include/linux/mm.h:4,
from sched.c:23:
/usr/include/linux/timex.h:173: field `time' has incomplete type
In file included from /usr/include/linux/bitops.h:69,
from /usr/include/asm/system.h:7,
from /usr/include/linux/sched.h:16,
from /usr/include/linux/mm.h:4,
from sched.c:23:
/usr/include/asm/bitops.h:333:2: warning: #warning This includefile is not avail
able on all architectures.
/usr/include/asm/bitops.h:334:2: warning: #warning Using kernel headers in users
pace.
In file included from /usr/include/linux/signal.h:4,
from /usr/include/linux/sched.h:25,
from /usr/include/linux/mm.h:4,
from sched.c:23:
/usr/include/asm/signal.h:107: parse error before "sigset_t"
/usr/include/asm/signal.h:110: parse error before '}' token
In file included from /usr/include/linux/timer.h:18,
from /usr/include/linux/sched.h:81,
from /usr/include/linux/mm.h:4,
from sched.c:23:
/usr/include/linux/spinlock.h:131: parse error before '*' token
In file included from /usr/include/linux/sched.h:81,
from /usr/include/linux/mm.h:4,
from sched.c:23:
/usr/include/linux/timer.h:32: field `vec' has incomplete type
/usr/include/linux/timer.h:37: field `vec' has incomplete type
/usr/include/linux/timer.h:63: field `list' has incomplete type
/usr/include/linux/timer.h:121: confused by earlier errors, bailing out
make[2]: *** [sched.o] Error 1
make[2]: Leaving directory `/home/joern/i386/linux-2.4.21-pre4/kernel'
make[1]: *** [first_rule] Error 2
make[1]: Leaving directory `/home/joern/i386/linux-2.4.21-pre4/kernel'
make: *** [_dir_kernel] Error 2
Jörn
--
Optimizations always bust things, because all optimizations are, in
the long haul, a form of cheating, and cheaters eventually get caught.
-- Larry Wall
^ permalink raw reply [flat|nested] 32+ messages in thread