public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Heinz <thomasheinz@gmx.net>
To: linux-kernel@vger.kernel.org
Subject: Concatenation of dynamic structs
Date: Tue, 04 Feb 2003 02:04:55 +0100	[thread overview]
Message-ID: <3E3F11B7.4010306@gmx.net> (raw)

Hi

Consider the following structs:

struct a
{
         char len;
         char c[0];
};

struct b
{
         char len;
         void *p[0];
};

Now, we have struct a *x; and we want to store n characters starting
from x->c. After the n characters we want a struct b to begin
which contains m pointers. Everything should be contained in one
contiguous memory block.

Now, several problems arise. First of all, if one wants to allocate
memory for x we cannot simply call
x = kmalloc(sizeof(*x) + n + sizeof(struct b) + m * sizeof(void *));

Instead we need something like this:
#define ALIGN(size, align) (((size) + ((align) - 1)) & (~ ((align) - 1)))
#define MAXALIGN (__alignof__(struct a) > __alignof__(struct b) ? \
                   __alignof__(struct a) : __alignof__(struct b))
x = kmalloc(ALIGN(sizeof(*x) + n, MAXALIGN) + m * sizeof(void *));


A second problem is how to define a macro (or inline function) that
returns a pointer to struct b within the concatenated struct.
Something like:
#define GETB(x) ((struct b *) ((char *) (x) + \
                   ALIGN(sizeof(*(x)) + (x)->len, MAXALIGN)))
should work.


Anyway, this is all very ugly. Is there any recommended, portable
solution for concatenating dynamic structs with different alignment
requirements?

Would it work in the general case if we define ALIGN the following way:
#define ALIGN(size) (((size) + ((__alignof__(u64)) - 1)) & \
                      (~ ((__alignof__(u64)) - 1)))

I.e. is __alignof__(u64) always the "strictest alignment requirement"
for all architectures?

Thanks for your help.
BTW, please cc your reply to my private e-mail since I'm currently
not subscribed.


Regards,

Thomas


                 reply	other threads:[~2003-02-04  0:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E3F11B7.4010306@gmx.net \
    --to=thomasheinz@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox