From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 733AF3F12C9 for ; Mon, 20 Jul 2026 11:05:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784545523; cv=none; b=or6vBVSUIC7n61+wIAuYaDlGW352TfSiEKYzZ4jLPew55kAC8W52s/0n5nCBDrS+w7n896uIGo7ZOwZ/KeLDcfpy/SVx5LP5ytKI/FeMuCRnY6x70XvZBtp7hiC+nR18yR46pkHT0DA+lXawvoNofOi0FJKKC8kEkI9kNWjw0MA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784545523; c=relaxed/simple; bh=NxaSAVqALje3f2mAzgST24XFr5iXGxoxryVh79nIIoM=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=XhKwBJl67Rgi7eDHILITla0u8jrnbga+sB36bsSscU8f9p4ZZS6A8akpUY657W9K9XfORhFJ11qPaoKVdEJlgc2NRo+rXZZ6LjVUL8TSQ9SgQ4aMVJ7ZTRSzhAcUnP98PBdGFqllxdxZjMCN5o1q1QvV8E0gEnSzoXje99lvoMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=RK0CYnUC; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="RK0CYnUC" Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784545515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LE7lXg74pYORpbuFx4QOJ0MptzoQRSngymT9gqZ/79o=; b=RK0CYnUCMrkf7s5idwexHk4YSU/n6GI0NkkE16RN6kbocii8IM+z4dsvTuE517nvs1+97m qNv/bV5xJHM1Kp6qtLRJu1xVmamUvZpcfZJnI3VPkbP51b00WscxYogMSymtIZHVyB9vX5 IJQy6tUT2NwLd6nk7RQiKzCssUU2dNY= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\)) Subject: Re: [PATCH v2 06/17] mm/mm_init: factor out pfn_to_zone() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20260720093127.540540-7-songmuchun@bytedance.com> Date: Mon, 20 Jul 2026 19:04:35 +0800 Cc: Andrew Morton , Oscar Salvador , David Hildenbrand , Mike Rapoport , Vlastimil Babka , Lorenzo Stoakes , Michal Hocko , David Laight , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <3E402DBA-58EC-4FA9-B1D6-33DC7185AE19@linux.dev> References: <20260720093127.540540-1-songmuchun@bytedance.com> <20260720093127.540540-7-songmuchun@bytedance.com> To: Muchun Song X-Migadu-Flow: FLOW_OUT > On Jul 20, 2026, at 17:31, Muchun Song wrote: > > pfn_to_zone() in hugetlb_vmemmap.c duplicates the zone lookup logic in > __init_deferred_page(). > > Move it to mm_init.c, declare it in mm/internal.h, and reuse it from > __init_deferred_page() and HugeTLB early vmemmap initialization instead > of open-coding the zone walk there. Sashiko said "the declaration is actually in mm/mm_init.h". That is indeed an issue. When I was handling the rebase, I forgot to update the commit message here due to code conflicts. I will fix this in the next version. Thanks.