From: Jeff Garzik <jgarzik@pobox.com>
To: Ballabio_Dario@emc.com
Cc: manfred@colorfullife.com, warp@mercury.d2dc.net,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-eata@i-connect.net
Subject: Re: eata irq abuse (was: Re: Linux 2.5.60)
Date: Wed, 12 Feb 2003 11:03:15 -0500 [thread overview]
Message-ID: <3E4A7043.1070200@pobox.com> (raw)
In-Reply-To: <3E4A6801.3050702@pobox.com>
Jeff Garzik wrote:
> Ballabio_Dario@emc.com wrote:
>
>> Yes, you are correct. I used spin_unlock in order to release the local
>> driver lock
>> during the scsi_register call, but I forgot that I had the irq
>> disabled as
>> well.
>> SO the correct fix is to use spin_unlock_irq/spin_lock_irq around the
>> scsi_register call. Same fix applies to the u14-34f driver.
>
> scsi_register may want to sleep, so that is not a fix at all...
Ooops, I missed the order. You (and Manfred) are right,
unlock-register-lock is desired.
ENOCAFFEINE, I plead...
next prev parent reply other threads:[~2003-02-12 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-12 10:08 eata irq abuse (was: Re: Linux 2.5.60) Ballabio_Dario
2003-02-12 15:28 ` Jeff Garzik
2003-02-12 16:03 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-02-11 17:45 Manfred Spraul
2003-02-11 23:01 ` Zephaniah E. Hull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E4A7043.1070200@pobox.com \
--to=jgarzik@pobox.com \
--cc=Ballabio_Dario@emc.com \
--cc=linux-eata@i-connect.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=warp@mercury.d2dc.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox