From: Jeff Garzik <jgarzik@pobox.com>
To: Dominik Brodowski <linux@brodo.de>
Cc: Paul Mackerras <paulus@samba.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: stuff-up in pcmcia/cardbus stuff
Date: Tue, 18 Feb 2003 04:23:45 -0500 [thread overview]
Message-ID: <3E51FBA1.7020208@pobox.com> (raw)
In-Reply-To: <20030218081529.GA2334@brodo.de>
Dominik Brodowski wrote:
> Indeed. socket->pcmcia_socket (old) == socket->cls_d.s_info[0] (new)
If this is true...
> @@ -230,14 +230,16 @@
> static int cardbus_suspend (struct pci_dev *dev, u32 state)
> {
> pci_socket_t *socket = pci_get_drvdata(dev);
> - pcmcia_suspend_socket (socket->pcmcia_socket);
> + if (socket && socket->cls_d.s_info[0])
> + pcmcia_suspend_socket (socket->cls_d.s_info[0]);
> return 0;
> }
>
> static int cardbus_resume (struct pci_dev *dev)
> {
> pci_socket_t *socket = pci_get_drvdata(dev);
> - pcmcia_resume_socket (socket->pcmcia_socket);
> + if (socket && socket->cls_d.s_info[0])
> + pcmcia_resume_socket (socket->cls_d.s_info[0]);
> return 0;
> }
1) ...why do you bother checking for NULL? Isn't NULL indicative of a
BUG(), instead?
2) why are multiple s_info records allocated, when you hardcode use of
record #0 ?
Jeff
next prev parent reply other threads:[~2003-02-18 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-18 1:50 stuff-up in pcmcia/cardbus stuff Paul Mackerras
2003-02-18 8:15 ` [PATCH] " Dominik Brodowski
2003-02-18 9:23 ` Jeff Garzik [this message]
2003-02-18 14:55 ` Dominik Brodowski
2003-02-18 22:14 ` [PATCH, updated] " Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E51FBA1.7020208@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@brodo.de \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox