From: Dave Hansen <haveblue@us.ibm.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix kirq code for clustered mode
Date: Tue, 18 Feb 2003 09:51:28 -0800 [thread overview]
Message-ID: <3E5272A0.80803@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
The new kirq code breaks clustered apic mode. This 2-liner fixes it.
It should compile down to the same thing, unless you're using a
clustered apic sub-arch.
--
Dave Hansen
haveblue@us.ibm.com
[-- Attachment #2: kirq-apicid-fix-2.5.62-2.patch --]
[-- Type: text/plain, Size: 1016 bytes --]
diff -ru linux-2.5.62-clean/arch/i386/kernel/io_apic.c linux-2.5.62-kirqfix/arch/i386/kernel/io_apic.c
--- linux-2.5.62-clean/arch/i386/kernel/io_apic.c Mon Feb 17 14:56:10 2003
+++ linux-2.5.62-kirqfix/arch/i386/kernel/io_apic.c Tue Feb 18 09:44:22 2003
@@ -441,7 +441,7 @@
Dprintk("irq = %d moved to cpu = %d\n", selected_irq, min_loaded);
/* mark for change destination */
spin_lock(&desc->lock);
- irq_balance_mask[selected_irq] = target_cpu_mask;
+ irq_balance_mask[selected_irq] = cpu_to_logical_apicid(min_loaded);
spin_unlock(&desc->lock);
/* Since we made a change, come back sooner to
* check for more variation.
@@ -515,7 +515,7 @@
/* push everything to CPU 0 to give us a starting point. */
for (i = 0 ; i < NR_IRQS ; i++)
- irq_balance_mask[i] = 1 << 0;
+ irq_balance_mask[i] = cpu_to_logical_apicid(0);
for (;;) {
set_current_state(TASK_INTERRUPTIBLE);
time_remaining = schedule_timeout(time_remaining);
Only in linux-2.5.62-kirqfix/arch/i386/kernel: io_apic.c~
next reply other threads:[~2003-02-18 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-18 17:51 Dave Hansen [this message]
2003-02-20 12:19 ` [PATCH] fix kirq code for clustered mode William Lee Irwin III
2003-02-20 12:29 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E5272A0.80803@us.ibm.com \
--to=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox