From: Manfred Spraul <manfred@colorfullife.com>
To: Daniel Jacobowitz <dan@debian.org>
Cc: fcorneli@elis.rug.ac.be, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptrace PTRACE_READDATA/WRITEDATA, kernel 2.5.62
Date: Mon, 24 Feb 2003 19:21:12 +0100 [thread overview]
Message-ID: <3E5A6298.3030601@colorfullife.com> (raw)
On Mon, Feb 24, 2003 at 03:05:14PM +0100, fcorneli@elis.rug.ac.be wrote:
>+ ret = 0;
>+ res = ptrace_readdata(child, addr, (void *)addr2, data);
>+ if (res == data)
>+ break;
>
>
You mention sparc - have you tested if that works on sparc?
ptrace_readdata assumes that addr2 is a pointer to kernel space, not
user space. It works by chance on i386, but that's not acceptable for
merging.
You must double buffer, check mem_read in fs/proc/base.c
Daniel wrote:
>Thirdly, I was going to do this, but I ended up making GDB use pread64
>on /dev/mem instead. It works with no kernel modifications, and is
>just as fast.
>
>
I assume you mean /proc/<pid>/mem. Performance is identical, same
implementation.
--
Manfred
next reply other threads:[~2003-02-24 18:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-24 18:21 Manfred Spraul [this message]
2003-02-25 10:36 ` [PATCH] ptrace PTRACE_READDATA/WRITEDATA, kernel 2.5.62 fcorneli
2003-02-25 17:35 ` Manfred Spraul
2003-02-25 21:36 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2003-02-24 14:05 fcorneli
2003-02-24 14:16 ` Daniel Jacobowitz
2003-02-24 14:51 ` fcorneli
2003-02-24 15:02 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E5A6298.3030601@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=dan@debian.org \
--cc=fcorneli@elis.rug.ac.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox