From: Nick Piggin <piggin@cyberone.com.au>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@digeo.com>, linux-kernel@vger.kernel.org
Subject: Re: anticipation is killing me
Date: Tue, 25 Feb 2003 10:05:03 +1100 [thread overview]
Message-ID: <3E5AA51F.20402@cyberone.com.au> (raw)
In-Reply-To: <Pine.LNX.4.44.0302242142570.1343-100000@localhost.localdomain>
Hugh Dickins wrote:
>With 2.5.62-mm3 (not -mm2) I need small patch to can_start_anticipation.
>I've not studied the code, this patch may be the worst nonsense; and if
>it's at all mysterious to you, sorry, I probably won't be able to give
>more info until tomorrow...
>
>Hugh
>
>--- 2.5.62-mm3/drivers/block/as-iosched.c Mon Feb 24 12:29:49 2003
>+++ linux/drivers/block/as-iosched.c Mon Feb 24 21:38:39 2003
>@@ -856,7 +856,8 @@
> */
> del_timer(&ad->antic_timer);
> ad->antic_status = ANTIC_FINISHED;
>- blk_remove_plug(arq->request->q);
>+ if (arq)
>+ blk_remove_plug(arq->request->q);
> schedule_work(&ad->antic_work);
> return 0;
> }
>
No that makes sense. We want to remove the plug even if
arq is null however so I'll have to pass it in I suppose.
prev parent reply other threads:[~2003-02-24 22:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-24 21:50 anticipation is killing me Hugh Dickins
2003-02-24 23:05 ` Nick Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E5AA51F.20402@cyberone.com.au \
--to=piggin@cyberone.com.au \
--cc=akpm@digeo.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox