* anticipation is killing me
@ 2003-02-24 21:50 Hugh Dickins
2003-02-24 23:05 ` Nick Piggin
0 siblings, 1 reply; 2+ messages in thread
From: Hugh Dickins @ 2003-02-24 21:50 UTC (permalink / raw)
To: Andrew Morton; +Cc: Nick Piggin, linux-kernel
With 2.5.62-mm3 (not -mm2) I need small patch to can_start_anticipation.
I've not studied the code, this patch may be the worst nonsense; and if
it's at all mysterious to you, sorry, I probably won't be able to give
more info until tomorrow...
Hugh
--- 2.5.62-mm3/drivers/block/as-iosched.c Mon Feb 24 12:29:49 2003
+++ linux/drivers/block/as-iosched.c Mon Feb 24 21:38:39 2003
@@ -856,7 +856,8 @@
*/
del_timer(&ad->antic_timer);
ad->antic_status = ANTIC_FINISHED;
- blk_remove_plug(arq->request->q);
+ if (arq)
+ blk_remove_plug(arq->request->q);
schedule_work(&ad->antic_work);
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: anticipation is killing me
2003-02-24 21:50 anticipation is killing me Hugh Dickins
@ 2003-02-24 23:05 ` Nick Piggin
0 siblings, 0 replies; 2+ messages in thread
From: Nick Piggin @ 2003-02-24 23:05 UTC (permalink / raw)
To: Hugh Dickins; +Cc: Andrew Morton, linux-kernel
Hugh Dickins wrote:
>With 2.5.62-mm3 (not -mm2) I need small patch to can_start_anticipation.
>I've not studied the code, this patch may be the worst nonsense; and if
>it's at all mysterious to you, sorry, I probably won't be able to give
>more info until tomorrow...
>
>Hugh
>
>--- 2.5.62-mm3/drivers/block/as-iosched.c Mon Feb 24 12:29:49 2003
>+++ linux/drivers/block/as-iosched.c Mon Feb 24 21:38:39 2003
>@@ -856,7 +856,8 @@
> */
> del_timer(&ad->antic_timer);
> ad->antic_status = ANTIC_FINISHED;
>- blk_remove_plug(arq->request->q);
>+ if (arq)
>+ blk_remove_plug(arq->request->q);
> schedule_work(&ad->antic_work);
> return 0;
> }
>
No that makes sense. We want to remove the plug even if
arq is null however so I'll have to pass it in I suppose.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-02-24 22:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-02-24 21:50 anticipation is killing me Hugh Dickins
2003-02-24 23:05 ` Nick Piggin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox