Re: [Bug 420] New: Divide by zero (/proc/sys/net/ipv4/neigh/DEV/base_reachable_time)

[Abramo Bagnara <abramo.bagnara@libero.it>]

Andi Kleen wrote:
> 
> "Martin J. Bligh" <mbligh@aracnet.com> writes:
> >
> >     echo 0 > /proc/sys/net/ipv4/neigh/DEV/base_reachable_time
> >
> >   But neigh_rand_reach_time() divide by its argument.
> >
> >     unsigned long neigh_rand_reach_time(unsigned long base)
> >     {
> >       return (net_random() % base) + (base>>1);
> >     }
> 
> Don't do that then. The sysctl is root-only. There are lots of ways to
> break the system by writing bogus values into root only configuration
> options. That is why they are root only
> 
> I would close the report as WONTFIX.

Don't this argument bring to the weird equality:

root user == infallible guy

IMHO the "if you make a typo you crash the machine" should be avoided
(at least when feasible without drawbacks).

-- 
Abramo Bagnara                       mailto:abramo.bagnara@libero.it

Opera Unica                          Phone: +39.546.656023
Via Emilia Interna, 140
48014 Castel Bolognese (RA) - Italy