Re: SWSUSP Discontiguous pagedir patch

Patrick Mochel
2003-03-10T19:13:18Z

> > > Hmm, I am not sure if drivers/power is the right place for stuff like
> > > fridge.c. That might be usefull for other stuff, too.
> >
> > That's fine. If it proves useful for other things, we can move it.
>
> Actually, I'd like driver model to specify that things are
> refrigerated when device_suspend() and friends are being run. That
> should make drivers a lot simpler. [And as non-bitkeeper-capable user
> I fear moves ;-)]

That's a policy decision outside of the scope of the driver model. It is
however, inside the scope of the PM model, and by using the generic
framework, this decision can be guaranteed to be made.

> > > I do not think placing swsusp.h in drivers/power/swsusp is right. It
> > > should be in include/linux or include/linux/power.
> >
> > That header is only for the shared functions between
> > drivers/power/swsusp/*.c. There's no need to export it to everyone.
>
> Well, last time acpi introduced its private include/ directory, it was
> a disaster.

I don't necessarily agree. IMO, putting things in include/whatever/ makes
it easy for other code to directly access those functions, some of which
you never want people calling directly. And, if it's there, it's likely
someone will use it someday.

But, in the end it's your code, so I don't really care.

-pat