From: Bryan Andersen <bryan@bogonomicon.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Oleg Drokin <green@linuxhacker.ru>,
alan@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
deanna_bonds@adaptec.com
Subject: Re: dpt_i2o.c memleak/incorrectness
Date: Thu, 13 Mar 2003 12:58:56 -0600 [thread overview]
Message-ID: <3E70D4F0.6060608@bogonomicon.net> (raw)
In-Reply-To: 1047584663.25948.75.camel@irongate.swansea.linux.org.uk
>> There is something strange going on in drivers/scsi/dpt_i2o.c in both
>> 2.4 and 2.5. adpt_i2o_reset_hba() function allocates 4 bytes
>> for "status" stuff, then tries to reset controller, then
>> if timeout on first reset stage is reached, frees "status" and returns,
>> otherwise it proceeds to monitor "status" (which is modified by hardware
>> now, btw), and if timeout is reached, just exits.
>
> Correctly - I2O does the same thing in this case. Its just better to
> throw a few bytes away than risk corruption
Better document it in the comments or it will get "corrected" by some
mem leak detector. If possible try to use a static for the pointer to
the status block, but that may not work. Re-enterant code and multi CPU
situations likely won't allow for that. Also it might not be worth the
effort to properly determin if it is safe to use only one location.
- Bryan
next prev parent reply other threads:[~2003-03-13 18:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-13 18:28 dpt_i2o.c memleak/incorrectness Oleg Drokin
2003-03-13 19:44 ` Alan Cox
2003-03-13 18:41 ` dpt_i2o.c fix for possibly memory corruption on reset timeout Oleg Drokin
2003-03-13 18:51 ` Randy.Dunlap
2003-03-13 18:56 ` Oleg Drokin
2003-03-14 9:18 ` Denis Vlasenko
2003-03-14 12:02 ` Joern Engel
2003-03-14 14:19 ` Alan Cox
2003-03-14 13:39 ` Joern Engel
2003-03-14 13:43 ` Oleg Drokin
2003-03-14 15:26 ` Alan Cox
2003-03-13 18:58 ` Bryan Andersen [this message]
2003-03-15 16:15 ` dpt_i2o.c memleak/incorrectness Horst von Brand
2003-03-13 19:38 ` Now i2o_core.c memleak/incorrectness? Oleg Drokin
2003-03-14 0:42 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E70D4F0.6060608@bogonomicon.net \
--to=bryan@bogonomicon.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=deanna_bonds@adaptec.com \
--cc=green@linuxhacker.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox