public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jon Grimm <jgrimm2@us.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Trivial Kernel Patches <trivial@rustcorp.com.au>,
	"David S. Miller" <davem@redhat.com>
Subject: Re: [PATCH] warning and unused in sctp.h
Date: Tue, 25 Mar 2003 09:00:03 -0600	[thread overview]
Message-ID: <3E806EF3.2000301@us.ibm.com> (raw)
In-Reply-To: 20030325142400.194987b0.sfr@canb.auug.org.au

Stephen Rothwell wrote:

> Hi,
> 
> This patch changes a flags argument to spin_lock_irq_save to unsigned long
> and removes its unused attribute.  The first gets rid of several warnings
> and the second is "obviously correct" (at least according to Rusty) :-).
> 

Hi Stephen.   What probably isn't obvious is that the same source is 
compiled into a user-level test harness where that variable really _is_ 
unused.  ;-)    However, this was just a hack to get rid of a 
compilation warning in the testsuite, so I'm glad to see it gone.

thanks!
-jon





      parent reply	other threads:[~2003-03-25 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-25  3:24 [PATCH] warning and unused in sctp.h Stephen Rothwell
2003-03-25  6:46 ` David S. Miller
2003-03-25 15:00 ` Jon Grimm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E806EF3.2000301@us.ibm.com \
    --to=jgrimm2@us.ibm.com \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox