Re: w83781d i2c driver updated for 2.5.66 (without sysfs support)

Martin Schlemmer
2003-03-26T23:26:35Z

[-- Attachment #1: Type: text/plain, Size: 857 bytes --]

On Wed, 2003-03-26 at 22:29, Greg KH wrote:

> Some of the nasty casts should be fixed up though. Stuff like:
>
> > + ERROR7:
> > + if (!is_isa)
> > + i2c_detach_client(&
> > + (((struct w83781d_data
> > + *) (i2c_get_clientdata(new_client)))->
> > + lm75[1]));
> > + ERROR6:
> > + if (!is_isa)
> > + i2c_detach_client(&
> > + (((struct w83781d_data
> > + *) (i2c_get_clientdata(new_client)))->
> > + lm75[0]));
> > + ERROR5:
> > + if (!is_isa)
> > + kfree(((struct w83781d_data *) (i2c_get_clientdata(new_client)))->
> > + lm75);
>
> Is just obnoxious :)
>

Quick question .... With sysfs, is it not needed to call
i2c_detach_client ? I am asking this as it seems from patches
that you remove all these calls ...

Regards,

--

Martin Schlemmer

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]