public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Greg KH <greg@kroah.com>
Cc: Stephan von Krawczynski <skraw@ithnet.com>,
	Chris Sykes <chris@sigsegv.plus.com>,
	linux-kernel@vger.kernel.org
Subject: Re: kernel BUG at sched.c:564! (2.4.20, 2.4.21-pre5-ac3)
Date: Thu, 27 Mar 2003 18:51:32 +0100	[thread overview]
Message-ID: <3E833A24.8060606@trash.net> (raw)
In-Reply-To: <20030327174503.GB32667@kroah.com>

Greg KH wrote:

>On Thu, Mar 27, 2003 at 01:35:27PM +0100, Patrick McHardy wrote:
>  
>
>>diff -Nru a/drivers/isdn/isdn_net.c b/drivers/isdn/isdn_net.c
>>--- a/drivers/isdn/isdn_net.c	Thu Mar 27 02:00:21 2003
>>+++ b/drivers/isdn/isdn_net.c	Thu Mar 27 02:00:21 2003
>>@@ -2831,6 +2831,7 @@
>> 
>> 			/* If binding is exclusive, try to grab the channel */
>> 			save_flags(flags);
>>+			cli();
>> 			if ((i = isdn_get_free_channel(ISDN_USAGE_NET,
>> 				lp->l2_proto, lp->l3_proto, drvidx,
>> 				chidx, lp->msn)) < 0) {
>>    
>>
>
>I thought that cli() was being removed from the kernel, not added :)
>
>This can not build on SMP, so you might want to change it.
>  
>

this patch is for 2.4, isdn_get_free_channel is protected by cli() 
everywhere.

Patrick



  reply	other threads:[~2003-03-27 17:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-26 16:25 kernel BUG at sched.c:564! (2.4.20, 2.4.21-pre5-ac3) Chris Sykes
2003-03-26 18:52 ` Greg KH
2003-03-26 19:25   ` Chris Sykes
2003-03-26 19:34     ` Greg KH
2003-03-27 11:16       ` Chris Sykes
2003-03-27 12:12         ` Stephan von Krawczynski
2003-03-27 12:35           ` Patrick McHardy
2003-03-27 15:52             ` Stephan von Krawczynski
2003-03-27 17:45             ` Greg KH
2003-03-27 17:51               ` Patrick McHardy [this message]
2003-03-27 17:58                 ` Greg KH
2003-03-27 17:46         ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2003-03-26 16:19 Chris Sykes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E833A24.8060606@trash.net \
    --to=kaber@trash.net \
    --cc=chris@sigsegv.plus.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skraw@ithnet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox