From: Jeff Garzik <jgarzik@pobox.com>
To: davej@codemonkey.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: init_etherdev conversion for sb1000
Date: Sat, 29 Mar 2003 00:10:07 -0500 [thread overview]
Message-ID: <3E852AAF.4090106@pobox.com> (raw)
In-Reply-To: <200303241642.h2OGg235008237@deviant.impure.org.uk>
davej@codemonkey.org.uk wrote:
> Also plugs leak by kfree'ing dev_sb1000 on exit.
>
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/net/sb1000.c linux-2.5/drivers/net/sb1000.c
> --- bk-linus/drivers/net/sb1000.c 2003-03-08 09:57:16.000000000 +0000
> +++ linux-2.5/drivers/net/sb1000.c 2003-03-17 23:42:27.000000000 +0000
> @@ -218,7 +218,7 @@ sb1000_probe(struct net_device *dev)
> "S/N %#8.8x, IRQ %d.\n", dev->name, dev->base_addr,
> dev->mem_start, serial_number, dev->irq);
>
> - dev = init_etherdev(dev, 0);
> + dev = init_etherdev(dev, sizeof(struct sb1000_private));
nope -- init_etherdev only allocs when it's first arg is NULL.
prev parent reply other threads:[~2003-03-29 4:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-24 16:41 init_etherdev conversion for sb1000 davej
2003-03-29 5:10 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E852AAF.4090106@pobox.com \
--to=jgarzik@pobox.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox