From: Jeff Garzik <jgarzik@pobox.com>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: xircom init_etherdev conversion.
Date: Sat, 29 Mar 2003 08:49:37 -0500 [thread overview]
Message-ID: <3E85A471.5000009@pobox.com> (raw)
In-Reply-To: <20030329110244.GA30863@suse.de>
Dave Jones wrote:
> On Sat, Mar 29, 2003 at 12:02:57AM -0500, Jeff Garzik wrote:
> > davej@codemonkey.org.uk wrote:
> > >- Also cleans up some exit paths.
> >
> > ...and now xircom_remove is kfree'ing memory that was never kmalloc'd
>
> Which one ? I don't see it..
"kfree(card)" here:
card=dev->priv;
...
kfree(card);
}
release_region(dev->base_addr, 128);
unregister_netdev(dev);
kfree(dev);
leave("xircom_remove");
prev parent reply other threads:[~2003-03-29 13:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-24 16:41 xircom init_etherdev conversion davej
2003-03-29 5:02 ` Jeff Garzik
2003-03-29 11:02 ` Dave Jones
2003-03-29 13:49 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E85A471.5000009@pobox.com \
--to=jgarzik@pobox.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox