[BUG] settimeofday(2) succeeds for microsecond value more than USEC_PER_SEC and for negative value

[BUG] settimeofday(2) succeeds for microsecond value more than USEC_PER_SEC and for negative value

[Aniruddha M Marathe]

Settimeofday(2) should return EINVAL in case where tv.tv_usec parameter is more than 
USEC_PER_SEC (more than 10^6 ) or for negative values of tv.tv_usec. 
It returns 0 (success) instead.

Clock_settimeofday(2) (kernel/posix-timers.c) also uses do_sys_settimeofday() and faces the
Same problem.

I think this is a bug. If you confirm, I will send a patch.

Regards,
Aniruddha Marathe
WIPRO Technologies, India

Re: [BUG] settimeofday(2) succeeds for microsecond value more than USEC_PER_SEC and for negative value

[george anzinger]

Aniruddha M Marathe wrote:
> Settimeofday(2) should return EINVAL in case where tv.tv_usec parameter is more than 
> USEC_PER_SEC (more than 10^6 ) or for negative values of tv.tv_usec. 
> It returns 0 (success) instead.
> 
> Clock_settimeofday(2) (kernel/posix-timers.c) also uses do_sys_settimeofday() and faces the
> Same problem.
> 
> I think this is a bug. If you confirm, I will send a patch.

Yes, it is a known problem, turned up by some the posix timers tests. 
  I suppose it is too much to ask, but it would be nice if 
do_sys_settimeofday() took a timespec instead of a timeval.  Of course 
this changes the interface for all the archs, but it would allow the 
clock_settimeofday to send in the nsec value.

-g

> 
> Regards,
> Aniruddha Marathe
> WIPRO Technologies, India
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
George Anzinger   george@mvista.com
High-res-timers:  http://sourceforge.net/projects/high-res-timers/
Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml

Re: [BUG] settimeofday(2) succeeds for microsecond value more thanUSEC_PER_SEC and for negative value

[Eric Piel]

george anzinger wrote:
> 
>   I suppose it is too much to ask, but it would be nice if
> do_sys_settimeofday() took a timespec instead of a timeval.  Of course
> this changes the interface for all the archs, but it would allow the
> clock_settimeofday to send in the nsec value.
IMHO on IA64 it would not be a bad idea since internally everything is
computed on nsec. Currently there is conversion from usec to nsec at the
beginning of do_sys_settimeofday() :-)
I could support you on IA64 to do the change if this is needed.

Eric