public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Andries Brouwer <aebr@win.tue.nl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kdevt-diff
Date: Wed, 16 Apr 2003 13:27:19 -0700	[thread overview]
Message-ID: <3E9DBCA7.2070608@zytor.com> (raw)
In-Reply-To: <20030416201948.GA18717@win.tue.nl>

Andries Brouwer wrote:
> On Wed, Apr 16, 2003 at 09:48:16AM -0700, H. Peter Anvin wrote:
> 
> 
>>Not really, but it's certainly a nice capability.  However, iso9660
>>(RockRidge, actually) has 64 bits of dev_t space; it's actually split
>>into two 32-bit entries specified as "high 32 bits" and "low 32 bits."
>>
>>I'm not positive if Linux expects those to contain major:minor or
>>0:<16-bit-dev_t>.
> 
>       case SIG('P','N'):
>         { int high, low;
>           high = isonum_733(rr->u.PN.dev_high);
>           low = isonum_733(rr->u.PN.dev_low);
>           /*
>            * The Rock Ridge standard specifies that if sizeof(dev_t) <= 4,
>            * then the high field is unused, and the device number is completely
>            * stored in the low field.  Some writers may ignore this subtlety,
>            * and as a result we test to see if the entire device number is
>            * stored in the low field, and use that.
>            */
>           if((low & ~0xff) && high == 0) {
>             inode->i_rdev = mk_kdev(low >> 8, low & 0xff);
>           } else {
>             inode->i_rdev = mk_kdev(high, low);
>           }
>         }
>         break;
> 
> (Here isonum_733 gets 32 bits.)

OK, in other words, it accepts either format, either:

0x000000000000MMmm or 0x000000MM000000mm

This is perfectly consistent with what dev_t does for a 32:32 split; the
previous form would be the "backwards compatibility" format and the
second the "new" format.

	-hpa


  reply	other threads:[~2003-04-16 20:16 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-14 22:01 [PATCH] kdevt-diff Andries.Brouwer
2003-04-14 22:11 ` Joel Becker
2003-04-14 22:18   ` Valdis.Kletnieks
2003-04-14 22:28     ` Joel Becker
2003-04-16 16:48     ` H. Peter Anvin
2003-04-16 20:19       ` Andries Brouwer
2003-04-16 20:27         ` H. Peter Anvin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-04-15 14:04 Andries.Brouwer
2003-04-15 14:53 ` Roman Zippel
2003-04-13 22:45 Andries.Brouwer
2003-04-14 17:51 ` Joel Becker
2003-04-14 18:00   ` Linus Torvalds
2003-04-14 19:15     ` Joel Becker
2003-04-14 19:34     ` Roman Zippel
2003-04-16 16:43     ` H. Peter Anvin
2003-04-14 18:12 ` Roman Zippel
2003-04-14 18:18   ` Linus Torvalds
2003-04-14 18:31     ` Roman Zippel
2003-04-14 18:40       ` Linus Torvalds
2003-04-14 19:28         ` Roman Zippel
2003-04-14 19:51           ` Linus Torvalds
2003-04-14 20:02             ` Roman Zippel
2003-04-15 13:37     ` Roman Zippel
2003-04-23 15:19       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E9DBCA7.2070608@zytor.com \
    --to=hpa@zytor.com \
    --cc=aebr@win.tue.nl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox