Re: USB deadlock in v2.5.67

Greg KH
2003-04-18T23:05:08Z

On Fri, Apr 18, 2003 at 08:46:56AM -0700, David Brownell wrote:
> Greg KH wrote:
> >On Thu, Apr 17, 2003 at 07:02:07PM -0700, David Mosberger wrote:
> >
> >><hcd_free_dev+0x140> translates into line 1249 in hcd.c, where it
> >>does:
> >>
> >> spin_lock_irqsave (&hcd_data_lock, flags);
> >>
> >>The deadlock is pretty obvious: the same lock has already been
> >>acquired urb_unlink(), 4 levels up in the call-chain.
> >>
> >>Anybody have a fix for this?
> >
> >
> >David (Brownell, that is), does this help with the trace I sent you a
> >few hours ago?
>
> Seems to be a different problem. The patch below should
> resolve the keyboard problem -- just reorders two lines
> so the lock isn't held after the device's records get
> deleted, so the order is what it should always have been.

Applied to my trees, thanks.

greg k-h