* [PATCH] hpt366.c compilation fix
@ 2003-04-20 18:23 Andries.Brouwer
2003-04-20 18:44 ` Alan Cox
2003-04-20 18:56 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Andries.Brouwer @ 2003-04-20 18:23 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel
Remove declaration of unused variables.
diff -u --recursive --new-file -X /linux/dontdiff a/drivers/ide/pci/hpt366.c b/drivers/ide/pci/hpt366.c
--- a/drivers/ide/pci/hpt366.c Sun Apr 20 12:59:31 2003
+++ b/drivers/ide/pci/hpt366.c Sun Apr 20 20:11:59 2003
@@ -1105,7 +1105,6 @@
(findev->device == dev->device) &&
((findev->devfn - dev->devfn) == 1) &&
(PCI_FUNC(findev->devfn) & 1)) {
- u8 irq = 0, irq2 = 0;
if (findev->irq != dev->irq) {
/* FIXME: we need a core pci_set_interrupt() */
findev->irq = dev->irq;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hpt366.c compilation fix
2003-04-20 18:23 [PATCH] hpt366.c compilation fix Andries.Brouwer
@ 2003-04-20 18:44 ` Alan Cox
2003-04-20 18:56 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2003-04-20 18:44 UTC (permalink / raw)
To: Andries.Brouwer; +Cc: Linus Torvalds, Linux Kernel Mailing List
On Sul, 2003-04-20 at 19:23, Andries.Brouwer@cwi.nl wrote:
> Remove declaration of unused variables.
>
> diff -u --recursive --new-file -X /linux/dontdiff a/drivers/ide/pci/hpt366.c b/drivers/ide/pci/hpt366.c
> --- a/drivers/ide/pci/hpt366.c Sun Apr 20 12:59:31 2003
> +++ b/drivers/ide/pci/hpt366.c Sun Apr 20 20:11:59 2003
> @@ -1105,7 +1105,6 @@
> (findev->device == dev->device) &&
> ((findev->devfn - dev->devfn) == 1) &&
> (PCI_FUNC(findev->devfn) & 1)) {
> - u8 irq = 0, irq2 = 0;
> if (findev->irq != dev->irq) {
> /* FIXME: we need a core pci_set_interrupt() */
> findev->irq = dev->irq;
Well it compiles regardless but yes that seems right to me
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hpt366.c compilation fix
2003-04-20 18:23 [PATCH] hpt366.c compilation fix Andries.Brouwer
2003-04-20 18:44 ` Alan Cox
@ 2003-04-20 18:56 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2003-04-20 18:56 UTC (permalink / raw)
To: Andries.Brouwer; +Cc: torvalds, linux-kernel
Andries.Brouwer@cwi.nl wrote:
> Remove declaration of unused variables.
Would you be open to changing your $subject in the future?
I think it is a bit misleading to call warning fixes "compilation
fixes", because by definition warnings to not break compilation,
therefore you are not fixing compilation :)
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-04-20 19:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-04-20 18:23 [PATCH] hpt366.c compilation fix Andries.Brouwer
2003-04-20 18:44 ` Alan Cox
2003-04-20 18:56 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox