Re: 2.4+ptrace exploit fix breaks root's ability to strace

Russell King
2003-03-23T10:27:54Z

On Sun, Mar 23, 2003 at 12:31:39PM +0200, Lists (lst) wrote:
> The patch breaks /proc/<pid>/cmdline and /proc/<pid>/environ for 'non
> dumpable' processes, even for root.

This fix is definitely wrong.

> - if (!is_dumpable(tsk) || (&init_mm == mm))
> + if ((!is_dumpable(tsk) || (&init_mm == mm)) && (current->uid != 0))
> mm = NULL;

Today, security is based around the capability system, not UID numbers.

--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux