Re: [PATCH 2.4.21-rc1] vesafb with large memory

Thomas Backlund
2003-05-03T12:34:41Z

Viestissä Perjantai 2. Toukokuuta 2003 16:03, Willy Tarreau kirjoitti:
> On Fri, May 02, 2003 at 03:14:01AM +0300, Thomas Backlund wrote:
> > And here are the results...
>
> [snip]
>
> Hi Thomas,
>
> With this patch, vesafb doesn't work anymore on my vaio notebook in
> 1400x1050 nor 1280x1024, because scree_info.lfb_size is reported to be
> 127, while it should be 175 and 160 instead ! So I modified your patch a
> little bit to get it right :
>
> - video_size = screen_info.lfb_size * screen_info.lfb_height *
> video_bpp; + video_size = screen_info.lfb_width/8 *
> screen_info.lfb_height * video_bpp;
>
> and it now works again.
> Maybe I have a broken bios, but other people might have the problem too.
>
> Cheers,
> Willy

Oh man...
I must have been sleeping when I posted that patch...

the correct line should AFAIK be:
video_size = screen_info.lfb_width * screen_info.lfb_height * video_bpp;

(AFAIK we are calculating bits here, not bytes so the '/8' you used is
wrong... could you try without it, and let me know...)

or even shorter:

video_size = video_width * video_height * video_bpp;

I'll be rebuilding and retesting my system today or tommorrow,
but I wuold like to hear if it works for you...

--
Thomas Backlund

tmb@iki.fi