From: David Brownell <david-b@pacbell.net>
To: Greg KH <greg@kroah.com>
Cc: Max Krasnyansky <maxk@qualcomm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-usb-devel@lists.sourceforge.net
Subject: Re: [linux-usb-devel] Re: [Bluetooth] HCI USB driver update. Support for SCO over HCI USB.
Date: Fri, 09 May 2003 17:48:16 -0700 [thread overview]
Message-ID: <3EBC4C50.8040304@pacbell.net> (raw)
In-Reply-To: 20030509230542.GA3267@kroah.com
Greg KH wrote:
> On Fri, May 09, 2003 at 03:35:36PM -0700, Max Krasnyansky wrote:
>
>>Ok. Sounds like it should be
>> uint32_t hcd_cb[16]; // 64 bytes for internal use by HCD
>> uint32_t drv_cb[2]; // 8 bytes for internal use by USB driver
>
>
> s/uint32_t/u32/ please.
"u32" is prettier, but is there actually a policy against using
the more standard type names? (POSIX, someone had said.)
> And if this is going to be used for pointers, why not just say they are
> pointers? Otherwise people are going to have to be careful with 32 vs.
> 64 bit kernels to not overrun their space.
>
> struct sk_buff uses a char, any reason not to use that here too? Has
> being a char made things more difficult for that structure over time?
No, it's just that in some similar cases having the value be "long"
(not "32 bit unsigned") has been simpler. I'm not religious.
- Dave
next prev parent reply other threads:[~2003-05-10 0:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200304290317.h3T3HOdA027579@hera.kernel.org>
2003-04-29 4:15 ` [Bluetooth] HCI USB driver update. Support for SCO over HCI USB Greg KH
2003-04-29 20:29 ` Max Krasnyansky
2003-04-29 21:15 ` Greg KH
2003-04-29 21:34 ` Oliver Neukum
2003-04-29 21:40 ` Greg KH
2003-04-29 22:24 ` [linux-usb-devel] " Oliver Neukum
2003-04-30 0:44 ` Max Krasnyansky
2003-04-30 7:06 ` Oliver Neukum
2003-04-29 21:55 ` Max Krasnyansky
2003-04-29 22:04 ` Greg KH
2003-04-29 21:39 ` [linux-usb-devel] " David Brownell
2003-04-29 21:37 ` Greg KH
2003-04-29 22:04 ` Max Krasnyansky
2003-04-30 4:55 ` David Brownell
2003-05-08 22:55 ` Max Krasnyansky
2003-05-09 19:06 ` David Brownell
2003-05-09 19:29 ` Greg KH
2003-05-09 22:35 ` Max Krasnyansky
2003-05-09 22:35 ` Max Krasnyansky
2003-05-09 23:05 ` Greg KH
2003-05-10 0:48 ` David Brownell [this message]
2003-05-10 5:06 ` Brad Hards
2003-05-10 5:40 ` Greg KH
2003-05-10 5:55 ` William Lee Irwin III
2003-05-10 6:11 ` Greg KH
2003-05-10 6:14 ` William Lee Irwin III
2003-05-12 17:53 ` Max Krasnyansky
2003-05-12 18:01 ` Greg KH
2003-05-12 18:55 ` Max Krasnyansky
2003-05-12 20:23 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EBC4C50.8040304@pacbell.net \
--to=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=maxk@qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox