public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix two bogus kfree(skb)
Date: Wed, 14 May 2003 17:29:29 +0200	[thread overview]
Message-ID: <3EC260D9.9050401@trash.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 132 bytes --]

This patch fixes two occurences of kfree(skb) in net/bridge/br_input.c and
net/decnet/netfilter/dn_rtmsg.c.

Best regards,
Patrick


[-- Attachment #2: net-bogus-kfree.diff --]
[-- Type: text/plain, Size: 1296 bytes --]

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1114  -> 1.1115 
#	net/bridge/br_input.c	1.11    -> 1.12   
#	net/decnet/netfilter/dn_rtmsg.c	1.1     -> 1.2    
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/05/14	kaber@trash.net	1.1115
# Fix bogus kfree in br_input.c and dn_rtmsg.c
# --------------------------------------------
#
diff -Nru a/net/bridge/br_input.c b/net/bridge/br_input.c
--- a/net/bridge/br_input.c	Wed May 14 17:26:31 2003
+++ b/net/bridge/br_input.c	Wed May 14 17:26:31 2003
@@ -64,7 +64,7 @@
 	smp_read_barrier_depends();
 
 	if (p == NULL || p->state == BR_STATE_DISABLED) {
-		kfree(skb);
+		kfree_skb(skb);
 		goto out;
 	}
 
diff -Nru a/net/decnet/netfilter/dn_rtmsg.c b/net/decnet/netfilter/dn_rtmsg.c
--- a/net/decnet/netfilter/dn_rtmsg.c	Wed May 14 17:26:31 2003
+++ b/net/decnet/netfilter/dn_rtmsg.c	Wed May 14 17:26:31 2003
@@ -55,7 +55,7 @@
 
 nlmsg_failure:
 	if (skb)
-		kfree(skb);
+		kfree_skb(skb);
 	*errp = -ENOMEM;
 	if (net_ratelimit())
 		printk(KERN_ERR "dn_rtmsg: error creating netlink message\n");

             reply	other threads:[~2003-05-14 15:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-14 15:29 Patrick McHardy [this message]
2003-05-14 21:00 ` [PATCH] fix two bogus kfree(skb) David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EC260D9.9050401@trash.net \
    --to=kaber@trash.net \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox