From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: set state to XFRM_STATE_DEAD before calling xfrm_state_put in pfkey_msg2xfrm_state
Date: Wed, 14 May 2003 22:29:38 +0200 [thread overview]
Message-ID: <3EC2A732.2080003@trash.net> (raw)
In-Reply-To: <20030514.131319.70202360.davem@redhat.com>
David S. Miller wrote:
>You didn't test this change. x->type is a pointer, not a place where
>you put XFRM_STATE_DEAD, a simple compile test would have alerted
>this to you.
>
>
Sorry about that, i recreated the fix in a different tree and broke it.
>This also means you couldn't possibly have tested if this even
>makes the assertion go away, it couldn't possibly have fixed this..
>
>The correct fix, of course, is to set x->km.state to this value.
>This is what I've done in my tree.
>
>Please be a LOT more careful with your changes.
>
Promised.
prev parent reply other threads:[~2003-05-14 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-14 15:00 [PATCH]: set state to XFRM_STATE_DEAD before calling xfrm_state_put in pfkey_msg2xfrm_state Patrick McHardy
2003-05-14 20:13 ` David S. Miller
2003-05-14 20:29 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EC2A732.2080003@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox