From: Douglas Gilbert <dougg@torque.net>
To: Andries.Brouwer@cwi.nl
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [patch] NCR5380.c fix
Date: Fri, 16 May 2003 09:16:25 +1000 [thread overview]
Message-ID: <3EC41FC9.4050504@torque.net> (raw)
In-Reply-To: <UTC200305152245.h4FMjAj26766.aeb@smtp.cwi.nl>
Andries.Brouwer@cwi.nl wrote:
> Several SCSI drivers confuse CHECK_CONDITION and CHECK_CONDITION << 1.
<snip>
Linux has always had SCSI status values that are masked
(reasonable) and shifted one bit right (bizarre) from
the equivalent values in the SCSI standards. This
has tricked lots of people.
So in lk 2.5 saner defines (with long-winded names)
have been introduced:
....
#define SAM_STAT_CHECK_CONDITION 0x02
....
The appropriate mask is now 0x7e since Linux uses
the upper bytes and the vendor could (but seldom)
use bits 0 and 7. We should have a constant or macro
for this mask.
So in lk 2.5 your check could read:
if ((cmd->SCp.Status & 0x7e) == SAM_STAT_CHECK_CONDITION)
Aside: "SAM" stands for SCSI Architecture Model which is the
modern standard that defines SCSI status values.
Doug Gilbert
next prev parent reply other threads:[~2003-05-15 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-15 22:45 [patch] NCR5380.c fix Andries.Brouwer
2003-05-15 22:52 ` James Bottomley
2003-05-15 23:16 ` Douglas Gilbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-05-15 23:10 Andries.Brouwer
2003-05-15 23:12 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EC41FC9.4050504@torque.net \
--to=dougg@torque.net \
--cc=Andries.Brouwer@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).