public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lionel Bouton <Lionel.Bouton@inet6.fr>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: alan@lxorguk.ukuu.org.uk, marcelo@conectiva.com.br,
	torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] Fix support for SiS5581/5582/5596 IDE
Date: Fri, 16 May 2003 16:13:17 +0200	[thread overview]
Message-ID: <3EC4F1FD.4010603@inet6.fr> (raw)
In-Reply-To: <20030516160222.A19746@ucw.cz>

Vojtech Pavlik wrote:

>Hi!
>
>The last patch for SiS96* also added support for SiS5581, SiS5582 and
>SiS5596. However, the PCI IDs for these three chips were incorrect by
>mistake (cut and paste problem). This patch, on top of the previous one
>fixes it, and thus adds proper support for these old chips.
>  
>

Thanks for the work.
I've yet to read carefully each change (will do this week-end), but I 
agree on the principles.

The only thing that disturbed me was the removal of the DEBUG code (as 
it often helped me find out bugs and understand new chips' behavior) but 
I think it's best for me to maintain a patch which adds this code in the 
very rare cases where it can be usefull.

LB.


  reply	other threads:[~2003-05-16 14:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-16 14:02 [patch] Fix support for SiS5581/5582/5596 IDE Vojtech Pavlik
2003-05-16 14:13 ` Lionel Bouton [this message]
2003-05-16 14:20   ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EC4F1FD.4010603@inet6.fr \
    --to=lionel.bouton@inet6.fr \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=torvalds@transmeta.com \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox