From: Rabeeh Khoury <rabeeh@il.marvell.com>
To: linux-kernel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Subject: Re: [RFR] a new SCSI driver
Date: Mon, 26 May 2003 18:16:12 +0300 [thread overview]
Message-ID: <3ED22FBC.50405@il.marvell.com> (raw)
In-Reply-To: <20030524195123.GA8394@gtf.org>
A small correction to the code -
While translating the GET_CAPACITY to ATA, you are returning the number of sectors the ATA drive but the GET_CAPACITY requests the last addressable sector.
So you should return (n_sectors-1).
static void ata_scsiop_read_cap(struct ata_scsi_args *args, u8 *reqbuf,
unsigned int buflen)
{
u64 n_sectors = args->dev->n_sectors;
u32 tmp;
+++ n_sectors --;
VPRINTK("ENTER\n");
next prev parent reply other threads:[~2003-05-26 14:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-24 19:51 [RFR] a new SCSI driver Jeff Garzik
2003-05-26 2:59 ` Douglas Gilbert
2003-05-26 20:52 ` Ishikawa
2003-05-26 15:16 ` Rabeeh Khoury [this message]
2003-05-27 11:38 ` Douglas Gilbert
-- strict thread matches above, loose matches on Subject: below --
2003-05-25 9:44 john
2003-05-25 8:52 ` Zwane Mwaikambo
2003-05-25 9:35 ` Russell King
2003-05-27 0:52 ` Alan Cox
2003-05-25 13:21 ` Jeff Garzik
2003-05-25 10:32 john
2003-05-25 11:19 john
2003-05-25 10:18 ` Zwane Mwaikambo
2003-05-28 18:25 ` Jörn Engel
2003-05-25 10:45 ` Arjan van de Ven
2003-05-25 11:48 ` Russell King
2003-05-25 11:48 john
2003-05-25 12:09 john
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ED22FBC.50405@il.marvell.com \
--to=rabeeh@il.marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox