* [PATCH] cleanup up seq file usage in resource.c
@ 2003-05-29 0:05 Jeff Muizelaar
2003-05-29 0:25 ` Jeff Muizelaar
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Muizelaar @ 2003-05-29 0:05 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 117 bytes --]
This patch against 2.5.70-bk2 removes the buffer allocation from
resource.c and lets seq_read do it instead.
-Jeff
[-- Attachment #2: resource-seq-file-cleanup.patch --]
[-- Type: text/plain, Size: 782 bytes --]
diff -urN linux-2.5.70-bk2/kernel/resource.c linux-2.5.70-bk2-resource-seq-file-cleanup/kernel/resource.c
--- linux-2.5.70-bk2/kernel/resource.c 2003-05-26 21:00:42.000000000 -0400
+++ linux-2.5.70-bk2-resource-seq-file-cleanup/kernel/resource.c 2003-05-28 19:22:04.000000000 -0400
@@ -71,20 +71,7 @@
static int ioresources_open(struct file *file, struct resource *root)
{
- char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
- struct seq_file *m;
- int res;
-
- if (!buf)
- return -ENOMEM;
- res = single_open(file, ioresources_show, root);
- if (!res) {
- m = file->private_data;
- m->buf = buf;
- m->size = PAGE_SIZE;
- } else
- kfree(buf);
- return res;
+ return single_open(file, ioresources_show, root);
}
static int ioports_open(struct inode *inode, struct file *file)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cleanup up seq file usage in resource.c
2003-05-29 0:05 [PATCH] cleanup up seq file usage in resource.c Jeff Muizelaar
@ 2003-05-29 0:25 ` Jeff Muizelaar
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Muizelaar @ 2003-05-29 0:25 UTC (permalink / raw)
To: Jeff Muizelaar; +Cc: Randy.Dunlap, Linux Kernel Mailing List
The extra 'up' does not belong in the subject.
-Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-05-29 0:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-05-29 0:05 [PATCH] cleanup up seq file usage in resource.c Jeff Muizelaar
2003-05-29 0:25 ` Jeff Muizelaar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox