Re: 2.4.20: Proccess stuck in __lock_page ...

Nick Piggin
2003-05-28T10:51:57Z

Con Kolivas wrote:

>On Wed, 28 May 2003 20:25, Jens Axboe wrote:
>
>>On Wed, May 28 2003, Andrew Morton wrote:
>>
>>>Then this (totally unlikely, don't bother):
>>>
>>>diff -puN drivers/block/ll_rw_blk.c~3 drivers/block/ll_rw_blk.c
>>>--- 24/drivers/block/ll_rw_blk.c~3 2003-05-28 03:21:15.000000000 -0700
>>>+++ 24-akpm/drivers/block/ll_rw_blk.c 2003-05-28 03:21:39.000000000 -0700
>>>@@ -829,8 +829,7 @@ void blkdev_release_request(struct reque
>>> */
>>> if (q) {
>>> list_add(&req->queue, &q->rq[rw].free);
>>>- if (++q->rq[rw].count >= q->batch_requests &&
>>>- waitqueue_active(&q->wait_for_requests[rw]))
>>>+ if (++q->rq[rw].count >= q->batch_requests)
>>> wake_up(&q->wait_for_requests[rw]);
>>> }
>>> }
>>>
>>Well it's the only one left :). But you are right, try one of them at
>>the time, establishing the effect of each of them.
>>
>
>THIS IS IT! The last one. No pauses writing a 2Gb file now unless I do a read
>midstream.
>
>
OK, I can't see how this would make a difference, but there
is similar (batch_requests) code in the mm tree, so it would
be nice if someone would work out what is going on.