public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Polyakov <appro@fy.chalmers.se>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.69-70 ide-cd to guarantee fault-free CD/DVD burning experience?
Date: Thu, 29 May 2003 15:50:54 +0200	[thread overview]
Message-ID: <3ED6103E.DFDAD2D8@fy.chalmers.se> (raw)
In-Reply-To: 20030528170347.GC845@suse.de

> > ... I noticed that DMA is never engaged
> > on that buffer allocated with kmalloc. The question is if it's
> > intentional? If answer is yes, then the case is dismissed. If not, then
> > it should be looked into...
> 
> Depends on the lower level driver, for ide-cd yes kmalloc'ed data will
> not be dma'ed to. We require a valid bio setup for that, usually the bio
> mapping will fail exactly because the length/alignment isn't correct for
> ide-cd.
> 
> > ... it might be appropriate to retry
> > bio_map_user on buffer. I'm actually stepping out of my competence
> > domains here...
> 
> It's usually not worth it. If the buffer is < 4 bytes, we don't dma. Big
> deal.

Well, I'm concerned rather about cases when user buffer ends up in non
DMA-able memory than small or misaligned buffers. I mean those who have
system with loads of RAM didn't do anything wrong, yet they get
"punished." But I'm not actually insisting! Just saying that it *might*
be worth reconsidering "ide-cd won't do dma without bio setup" clause or
retry bio_map_user on kalloc-ed buffer. At least for transfers not
smaller than say 2K:-)

Cheers. A.

  reply	other threads:[~2003-05-29 13:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-28  7:41 2.5.69-70 ide-cd to guarantee fault-free CD/DVD burning experience? Andy Polyakov
2003-05-28  7:48 ` Jens Axboe
2003-05-28  7:52   ` Jens Axboe
2003-05-28 16:42   ` Andy Polyakov
2003-05-28 17:03     ` Jens Axboe
2003-05-29 13:50       ` Andy Polyakov [this message]
2003-05-29 17:33         ` Jens Axboe
2003-05-28  7:49 ` Jens Axboe
2003-06-04 19:42 ` Andy Polyakov
2003-06-04 19:55   ` Jens Axboe
2003-06-05 21:05     ` Andy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ED6103E.DFDAD2D8@fy.chalmers.se \
    --to=appro@fy.chalmers.se \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox