From: David Brownell <david-b@pacbell.net>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net
Subject: Re: [2.5 patch] let USB_GADGET depend on USB
Date: Sat, 31 May 2003 16:39:28 -0700 [thread overview]
Message-ID: <3ED93D30.4070704@pacbell.net> (raw)
In-Reply-To: 20030531221855.GM29425@fs.tum.de
Adrian Bunk wrote:
> USB_GADGET is still selectable even with USB disabled. It seems the
> following is intended:
This is wrong.
CONFIG_USB has always represented the master/host side ... while
CONFIG_USB_GADGET represents just the slave/gadget side.
The two are completely independent. Hardware that supports
one will typically _not_ support the other. And systems
that support the slave/gadget side will have no use at all
for the 100KB+ of "usbcore".
If you want CONFIG_USB_GADGET to depend on USB, then you're
going to need to change the meaning of CONFIG_USB so that it
becomes just an "umbrella" ... and change EVERYTHING that
currently depends on CONFIG_USB to depend on some new config
varaible representing just the host side (which also depends
on CONFIG_USB). That sort of change seems pointless.
> --- linux-2.5.70-mm3/drivers/usb/gadget/Kconfig.old 2003-06-01 00:15:30.000000000 +0200
> +++ linux-2.5.70-mm3/drivers/usb/gadget/Kconfig 2003-06-01 00:15:49.000000000 +0200
> @@ -8,7 +8,7 @@
> #
> menuconfig USB_GADGET
> tristate "Support for USB Gadgets"
> - depends on EXPERIMENTAL
> + depends on USB && EXPERIMENTAL
> help
> USB is a master/slave protocol, organized with one master
> host (such as a PC) controlling up to 127 peripheral devices.
>
>
>
> cu
> Adrian
>
next prev parent reply other threads:[~2003-05-31 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-31 22:18 [2.5 patch] let USB_GADGET depend on USB Adrian Bunk
2003-05-31 23:39 ` David Brownell [this message]
2003-06-01 11:13 ` Adrian Bunk
2003-06-01 14:18 ` David Brownell
2003-06-01 18:10 ` Greg KH
2003-06-01 18:40 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ED93D30.4070704@pacbell.net \
--to=david-b@pacbell.net \
--cc=bunk@fs.tum.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox