public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Andrew Morton <akpm@digeo.com>,
	greg@kroah.com, linux-kernel@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net
Subject: Re: [patch] 2.5.70-mm3: usb_gadget_* several times defined
Date: Sat, 31 May 2003 16:41:37 -0700	[thread overview]
Message-ID: <3ED93DB1.1080301@pacbell.net> (raw)
In-Reply-To: 20030531210752.GK29425@fs.tum.de

Adrian Bunk wrote:

> 
> The following patch fixes it (drivers/usb/Makefile now includes gadget/
> entries):


No, the better fix is to revert whatever change added
USB_GADGET into drivers/usb/Makefile ... the slave/gadget
side API needs to be independent of the master/host side
code.



> --- linux-2.5.70-mm3/drivers/Makefile.old	2003-05-31 23:00:25.000000000 +0200
> +++ linux-2.5.70-mm3/drivers/Makefile	2003-05-31 23:00:44.000000000 +0200
> @@ -37,7 +37,6 @@
>  obj-$(CONFIG_PARIDE) 		+= block/paride/
>  obj-$(CONFIG_TC)		+= tc/
>  obj-$(CONFIG_USB)		+= usb/
> -obj-$(CONFIG_USB_GADGET)	+= usb/gadget/
>  obj-$(CONFIG_INPUT)		+= input/
>  obj-$(CONFIG_GAMEPORT)		+= input/gameport/
>  obj-$(CONFIG_SERIO)		+= input/serio/
> 
> 
> 
> cu
> Adrian
> 




  reply	other threads:[~2003-05-31 23:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-31  8:37 2.5.70-mm3 Andrew Morton
2003-05-31 13:56 ` [patch] 2.5.70-mm3: sdla.c doesn't compile Adrian Bunk
2003-05-31 14:07   ` Christoph Hellwig
2003-05-31 14:09 ` 2.5.70-mm3: LVM/device-mapper seems broken Sean Neakums
2003-05-31 14:18   ` Christophe Saout
2003-05-31 15:01     ` Sean Neakums
2003-05-31 15:11       ` Sean Neakums
2003-05-31 21:07 ` [patch] 2.5.70-mm3: usb_gadget_* several times defined Adrian Bunk
2003-05-31 23:41   ` David Brownell [this message]
2003-05-31 22:02 ` 2.5.70-mm3 Jordan Breeding
2003-06-02  9:17 ` 2.5.70-mm3 Alistair J Strachan
2003-06-02  9:29   ` 2.5.70-mm3 Andrew Morton
2003-06-02 10:06     ` 2.5.70-mm3 Alistair J Strachan
2003-06-03 16:51 ` 2.5.70-mm3 Mingming Cao
2003-06-03 17:39   ` 2.5.70-mm3 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ED93DB1.1080301@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=akpm@digeo.com \
    --cc=bunk@fs.tum.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox