From: Brian Gerst <bgerst@didntduck.org>
To: Stuart MacDonald <stuartm@connecttech.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Redundant code?
Date: Mon, 02 Jun 2003 11:42:11 -0400 [thread overview]
Message-ID: <3EDB7053.3040707@didntduck.org> (raw)
In-Reply-To: <00e301c3291c$22d4f270$294b82ce@stuartm>
Stuart MacDonald wrote:
> Seems to me the following is redundant code, since get_fd_set also
> memsets the fds.res_* bitmaps.
>
> ..Stu
>
> --- linux-2.5.70/fs/select.c 2003-05-26 21:00:21.000000000 -0400
> +++ linux-2.5.70-new/fs/select.c 2003-06-02 11:40:24.000000000 -0400
> @@ -344,9 +344,6 @@
> (ret = get_fd_set(n, outp, fds.out)) ||
> (ret = get_fd_set(n, exp, fds.ex)))
> goto out;
> - zero_fd_set(n, fds.res_in);
> - zero_fd_set(n, fds.res_out);
> - zero_fd_set(n, fds.res_ex);
>
> ret = do_select(n, &fds, &timeout);
>
>
fds.in != fds.res_in
--
Brian Gerst
next prev parent reply other threads:[~2003-06-02 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-02 15:32 Redundant code? Stuart MacDonald
2003-06-02 15:42 ` Brian Gerst [this message]
2003-06-02 15:58 ` Stuart MacDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EDB7053.3040707@didntduck.org \
--to=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stuartm@connecttech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox