Re: 2.5.70 add_disk(disk) re-registering disk->queue->elevator.kobj (bug?!)

viro
2003-06-04T00:42:58Z

On Tue, Jun 03, 2003 at 06:29:19PM -0600, Lou Langholtz wrote:
> Andrew Morton wrote:
> >The ramdisk driver was recently changed to do exactly this. From what
> >you say it appears that nbd needs the same treatment.

This is utterly ridiculous. I realize that sysfs is fashionable, but
it should reflect the existing logics, not the other way round.

Guys, there are very valid reasons to have a queue shared by several
disks. E.g. it can very well act as a serialization mechanism - and
as the matter of fact does in quite a few drivers.

What the fuck is going on? It's what, the fifth case when we have
somebody export something in sysfs, ignore the lifetime rules for
objects and go "reality doesn't match my theory, too bad for reality"?

Linus, could we *please* put a moratorium on use of sysfs unless the
persons using it had proven that they understand how the objects they
export are used in the tree? Enough is enough - we already have netdev
drivers to deal with and have to do that *now* thanks to blind sysfs
export. Now we get random bdev stuff on top of that? Absofuckinglutely
marvelous.