fix TCP roundtrip time update code

David Mosberger
2003-06-03T15:39:27Z

One of those very-hard-to-track-down, trivial-to-fix kind of problems:
without this patch, TCP roundtrip time measurements will corrupt the
routing cache's RTT estimates under heavy network load (the bug causes
RTAX_RTT to go negative, but since its type is u32, you end up with a
huge positive value...). From there on, later TCP connections quickly
will go south.

The typo was introduced 8 months ago in v1.29 of the file by the patch
entitled "Cleanup DST metrics and abstrct MSS/PMTU further".

--david

===== net/ipv4/tcp_input.c 1.36 vs edited =====
--- 1.36/net/ipv4/tcp_input.c Mon Apr 28 09:27:57 2003
+++ edited/net/ipv4/tcp_input.c Tue Jun 3 08:19:36 2003
@@ -556,8 +556,8 @@
if (m >= dst_metric(dst, RTAX_RTTVAR))
dst->metrics[RTAX_RTTVAR-1] = m;
else
- dst->metrics[RTAX_RTT-1] -=
- (dst->metrics[RTAX_RTT-1] - m)>>2;
+ dst->metrics[RTAX_RTTVAR-1] -=
+ (dst->metrics[RTAX_RTTVAR-1] - m)>>2;
}

if (tp->snd_ssthresh >= 0xFFFF) {