From: Matthew Dobson <colpatch@us.ibm.com>
To: Trivial Patch Monkey <trivial@rustcorp.com.au>,
"Martin J. Bligh" <mbligh@aracnet.com>,
linux-kernel@vger.kernel.org
Subject: [patch] use valid value when unmapping cpus
Date: Wed, 04 Jun 2003 14:26:22 -0700 [thread overview]
Message-ID: <3EDE63FE.1010603@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
For some unknown reason, we stick a -1 in cpu_2_node when we unmap a cpu
on i386. We're better off sticking a 0 in there, because at least 0 is
a valid value if something references it. -1 is only going to cause
problems at some point down the line. Besides, we initialize the array
with 0's, so undoing it should return it to that same value.
Cheers!
-Matt
[-- Attachment #2: i386_smpboot_fix.patch --]
[-- Type: text/plain, Size: 398 bytes --]
--- linux-2.5.70-vanilla/arch/i386/kernel/smpboot.c Mon Mar 24 14:00:35 2003
+++ linux-2.5.70-vanilla/arch/i386/kernel/smpboot.c.fixed Wed Apr 2 18:23:06 2003
@@ -520,7 +520,7 @@
printk("Unmapping cpu %d from all nodes\n", cpu);
for (node = 0; node < MAX_NR_NODES; node ++)
node_2_cpu_mask[node] &= ~(1 << cpu);
- cpu_2_node[cpu] = -1;
+ cpu_2_node[cpu] = 0;
}
#else /* !CONFIG_NUMA */
next reply other threads:[~2003-06-04 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 21:26 Matthew Dobson [this message]
2003-06-09 5:20 ` [patch] use valid value when unmapping cpus Matt Mackall
2003-06-09 16:59 ` Matthew Dobson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EDE63FE.1010603@us.ibm.com \
--to=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox