Re: Coding standards. (Was: Re: [PATCH] [2.5] Non-blocking write can block)

[Timothy Miller <miller@techsource.com>]

Davide Libenzi wrote:
> On Mon, 9 Jun 2003, [iso-8859-1] J?rn Engel wrote:
> 
> 
>>In the case of the kernel, there is quite a bit of horrible coding
>>style.  But a working device driver for some hardware is always better
>>that no working device driver for some hardware, and if enforcing the
>>coding style more results is scaring away some driver writers, the
>>style clearly loses.
> 
> 
> There's no such a thing as "horrible coding style", since coding style is
> strictly personal. Whoever try to convince you that one style is better
> than another one is simply plain wrong. Every reason they will give you to
> justify one style can be wiped with other opposite reasons. The only
> horrible coding style is to not respect coding standards when you work
> inside a project. This is a form of respect for other people working
> inside the project itself, give the project code a more professional
> look and lower the fatigue of reading the project code. Jumping from 24
> different coding styles does not usually help this. I do not believe
> professional developers can be scared by a coding style, if this is the
> coding style adopted by the project where they have to work in.

Oh, yes, there is most certainly "horrible coding style".  When I was in 
college, I met one CS student after another who really just did not 
belong in CS, and you should have seen the code they wrote.

Imagine a 200 line program which is ALL inside of main().  There is no 
indenting.  Lines of code are broken in random places.  Blank lines are 
inserted randomly.  The variable names chosen are a, b, c, d, e, etc. 
It's impossible to tell which '{' is associated with which '}'.

It's been a while.  I can't remember all of the violations of reason and 
sanity I saw.  I pity the grad students who were faced with grading 
these monstrosities.