From: jgmyers@netscape.com (John Myers)
To: Daniel McNeil <daniel@osdl.org>
Cc: Andrew Morton <akpm@digeo.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-aio@kvack.org" <linux-aio@kvack.org>
Subject: Re: [PATCH 2.5.71-mm1] aio process hang on EINVAL
Date: Mon, 16 Jun 2003 18:33:13 -0700 [thread overview]
Message-ID: <3EEE6FD9.2050908@netscape.com> (raw)
In-Reply-To: <1055810609.1250.1466.camel@dell_ss5.pdx.osdl.net>
Daniel McNeil wrote:
>Are there other error return values where it should jump to the
>aio_put_req()? Should the check be:
>
>
The situation is much worse. The io_submit_one() code in 2.5.71
distinguishes between conditions where io_submit should fail (which goto
out_put_req) and conditions where the queued operation completes
immediately (which result in a call to aio_complete()). The patch in
2.5.71-mm1 which separates out aio_setup_iocb() loses track of this
distinction, mishandling any case where the queued operation completes
immediately. Aio poll, for instance, depends on being able to indicate
immediate completion.
So the part of aio-01-retry.patch that splits out aio_setup_iocb() is
completely broken.
next prev parent reply other threads:[~2003-06-17 1:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-17 0:43 [PATCH 2.5.71-mm1] aio process hang on EINVAL Daniel McNeil
2003-06-17 1:33 ` John Myers [this message]
2003-06-17 3:24 ` Suparna Bhattacharya
2003-06-17 18:31 ` John Myers
2003-06-17 21:06 ` Daniel McNeil
2003-06-18 0:03 ` John Myers
2003-06-18 0:15 ` Joel Becker
2003-06-18 0:25 ` John Myers
2003-06-18 0:42 ` Joel Becker
2003-06-19 0:33 ` John Myers
2003-06-19 0:41 ` Joel Becker
2003-06-19 0:58 ` John Myers
2003-06-19 1:48 ` Scot McKinley
2003-06-19 20:54 ` John Myers
2003-06-19 22:42 ` Scot McKinley
2003-06-18 5:11 ` Scot McKinley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EEE6FD9.2050908@netscape.com \
--to=jgmyers@netscape.com \
--cc=akpm@digeo.com \
--cc=daniel@osdl.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox