* Linux 2.5.72: ixgb_ethtool: strange SUPPORTED_10000baseT_Full
@ 2003-06-17 20:34 Adrian Bunk
2003-06-17 20:36 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2003-06-17 20:34 UTC (permalink / raw)
To: Jeff Garzik, Linux NICS; +Cc: linux-kernel, linux-net
<-- snip -->
...
CC drivers/net/ixgb/ixgb_ethtool.o
drivers/net/ixgb/ixgb_ethtool.c:53:1: warning: "SUPPORTED_10000baseT_Full" redefined
In file included from drivers/net/ixgb/ixgb.h:60,
from drivers/net/ixgb/ixgb_ethtool.c:30:
include/linux/ethtool.h:302:1: warning: this is the location of the previous definition
...
<-- snip -->
ixgb_ethtool.c says:
#define SUPPORTED_10000baseT_Full (1 << 11)
ethtool.h says:
#define SUPPORTED_BNC (1 << 11)
#define SUPPORTED_10000baseT_Full (1 << 12)
The correct solution seems to be to remove the #define from
ixgb_ethtool.c ?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Linux 2.5.72: ixgb_ethtool: strange SUPPORTED_10000baseT_Full
2003-06-17 20:34 Linux 2.5.72: ixgb_ethtool: strange SUPPORTED_10000baseT_Full Adrian Bunk
@ 2003-06-17 20:36 ` Jeff Garzik
2003-06-17 20:43 ` Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2003-06-17 20:36 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Linux NICS, linux-kernel, linux-net
Adrian Bunk wrote:
> The correct solution seems to be to remove the #define from
> ixgb_ethtool.c ?
correct.
wanna send a patch? ;-)
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Linux 2.5.72: ixgb_ethtool: strange SUPPORTED_10000baseT_Full
2003-06-17 20:36 ` Jeff Garzik
@ 2003-06-17 20:43 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2003-06-17 20:43 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Linux NICS, linux-kernel, linux-net
On Tue, Jun 17, 2003 at 04:36:03PM -0400, Jeff Garzik wrote:
> Adrian Bunk wrote:
> >The correct solution seems to be to remove the #define from
> >ixgb_ethtool.c ?
>
>
> correct.
>
> wanna send a patch? ;-)
Yup. :-)
Compilation tested with 2.5.72.
--- linux-2.5.72/drivers/net/ixgb/ixgb_ethtool.c.old 2003-06-17 22:40:40.000000000 +0200
+++ linux-2.5.72/drivers/net/ixgb/ixgb_ethtool.c 2003-06-17 22:40:55.000000000 +0200
@@ -50,7 +50,6 @@
return (IXGB_EEPROM_SIZE << 1);
}
-#define SUPPORTED_10000baseT_Full (1 << 11)
#define SPEED_10000 10000
static void
> Jeff
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-06-17 20:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-06-17 20:34 Linux 2.5.72: ixgb_ethtool: strange SUPPORTED_10000baseT_Full Adrian Bunk
2003-06-17 20:36 ` Jeff Garzik
2003-06-17 20:43 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox