public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ray Bryant <raybry@sgi.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: Bug in __pollwait() can cause select() and poll() to hang  in   2.4.21
Date: Thu, 19 Jun 2003 12:18:08 -0500	[thread overview]
Message-ID: <3EF1F050.2FBFA654@sgi.com> (raw)
In-Reply-To: p733ci65894.fsf@oldwotan.suse.de

Andi Kleen wrote:
> 
> Nasty bug. How about adding a BUG() for current->state != TASK_RUNNING at
> the beginning of __alloc_pages unless GFP_ATOMIC is set?
> 
> -Andi

A good idea.  There may be other places like this that call into
__alloc_pages() with current->state != TASK_RUNNING.

However, this may break otherwise happily running kernels being used in
production today that are not in low memory situations.  Might it not be
better for me to run this in debug mode and see if we can find other
places where this is happening?  If I don't find any, then we can add
the BUG() as a way to avoid future introductions of this problem.

-- 
Best Regards,
Ray
-----------------------------------------------
                  Ray Bryant
512-453-9679 (work)         512-507-7807 (cell)
raybry@sgi.com             raybry@austin.rr.com
The box said: "Requires Windows 98 or better",
           so I installed Linux.
-----------------------------------------------

  reply	other threads:[~2003-06-19 17:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3EF1D830.F12113D@sgi.com.suse.lists.linux.kernel>
2003-06-19 16:42 ` PROBLEM: Bug in __pollwait() can cause select() and poll() to hang in 2.4.21 Andi Kleen
2003-06-19 17:18   ` Ray Bryant [this message]
2003-06-19 15:35 Ray Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EF1F050.2FBFA654@sgi.com \
    --to=raybry@sgi.com \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox