From: Thomas Winischhofer <twini@xfree86.org>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] SiS IRQ router 96x detection (2.5.69) ...
Date: Sun, 22 Jun 2003 03:58:27 +0200 [thread overview]
Message-ID: <3EF50D43.6020809@xfree86.org> (raw)
In-Reply-To: <Pine.LNX.4.55.0306211314400.3725@bigblue.dev.mcafeelabs.com>
Davide Libenzi wrote:
> I have to admit that I was tempted to let this go through by simply
> ignoring you.
Ouch, this hurts. The lawyer in me just told me that this is no proper
way to argue. And he means both sides. I think he's right.
Davide, calm down and take a deep breath. Better? :) Alan probably
receives thousands of mails every day and he therefore tends to make it
somewhat very short sometimes. Be happy that he even aswered at all, right?
You got a point, though. The only issue Alan mentioned was the NULL
initialisation.
Let's give Alan another chance to explain (shortly) why he thought your
patch was ugly - would you, Alan?
Point is, this is a serious issue. IRQ routing is nothing that should be
decided over beauty. Alan, you obviously saw the code. Are you perhaps
willing to make a better patch if you're that unsatisfied with the
current one?
Thomas
--
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net http://www.winischhofer.net/
twini AT xfree86 DOT org
next prev parent reply other threads:[~2003-06-22 1:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-03 6:44 [patch] SiS IRQ router 96x detection (2.5.69) Davide Libenzi
2003-06-19 23:36 ` Thomas Winischhofer
2003-06-20 19:14 ` Davide Libenzi
2003-06-21 12:23 ` Alan Cox
2003-06-21 20:49 ` Davide Libenzi
2003-06-22 1:58 ` Thomas Winischhofer [this message]
2003-06-22 3:52 ` Davide Libenzi
2003-06-22 8:25 ` Paul Rolland
2003-06-22 11:40 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EF50D43.6020809@xfree86.org \
--to=twini@xfree86.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox