Kernel Panic in 2.5.73-mm1 OOps part.

Kernel Panic in 2.5.73-mm1 OOps part.

[jds]

Hi Andrew:


    I have kernel panic when boot with kernel 2.5.73-mm1, in kernel 2.5.73
working good.

    Anex part the OOps:


    EPI: 0060:[<c20f480>]   not tainted VLI
    EFLAHS: 0010246
    EIP:   is at kobject_add+0xd0/0130
    eax: 736f70a3 ebx:736f705f  ecx:00000000   edx:ffff0001
    esi: 736f70a3 edi:dfd6653x  ebp:c157df40   esp:c157df24
    ds:  007b  es: 007b  ss:  0068

    Process:   swapper( pid:1, theaddinfo= c157c000 task = c157f880)
    
    Stack:

    c03ed505  00000059  dfd6653c  dfd80860  dfd66400 dfd653c  c157f75c
     
  
    Call Trace:

    [< c020f503>]  kobject_register+0x23/0x60
    [<             blk_register_queue+0x80/0xb0
                   nbd_init+0x1df/0x220
                   do_initcalls+0x2b/0xa0
                   init_workqueues+0x12/0x30
                   init+0x28/0x150
                   init+0x0/0x150
                   kernel_thread_helper+0x50/0xc

   Code: feff
   <0>Kernel Panic:  Attempted to kill init!


   Helpme please.

   Regards.

Re: Kernel Panic in 2.5.73-mm1 OOps part.

[Andrew Morton]

"jds" <jds@soltis.cc> wrote:
>
> 
> 
> Hi Andrew:
> 
> 
>     I have kernel panic when boot with kernel 2.5.73-mm1, in kernel 2.5.73
> working good.
> 

Please disable CONFIG_BLK_DEV_NBD.   We're working on it.

Re: Kernel Panic in 2.5.73-mm1 OOps part.

[Lou Langholtz]

jds wrote:

>Hi Andrew:
>
>
>    I have kernel panic when boot with kernel 2.5.73-mm1, in kernel 2.5.73
>working good.
>
>    Anex part the OOps: . . .
>
>    [< c020f503>]  kobject_register+0x23/0x60
>    [<             blk_register_queue+0x80/0xb0
>                   nbd_init+0x1df/0x220
>                   do_initcalls+0x2b/0xa0
>                   init_workqueues+0x12/0x30
>                   init+0x28/0x150
>                   init+0x0/0x150
>                   kernel_thread_helper+0x50/0xc
>. . .
>
I think this is my fault. I introduced a patch to nbd that apparantly 
doesn't use the block layer quite the way the block layer developers 
expect. As you found, it works on 2.5.73 but not in 2.5.73-mm1. I'm 
looking into why exactly this is so I can get a fix ASAP. In the 
meantime, if you take out the network block driver you shouldn't get 
this oops anymore.

Re: Kernel Panic in 2.5.73-mm1 OOps part.

[jds]

Hi Andrew, lou:

   Diseable the # CONFIG_BLK_DEV_NBD is not set, in .config, compile again
kernel and working good.

   Thanks .... :)

   Iam testings my new kernel mm1

   Regards.


---------- Original Message -----------
From: Lou Langholtz <ldl@aros.net>
To: jds <jds@soltis.cc>
Sent: Tue, 24 Jun 2003 14:15:24 -0600
Subject: Re: Kernel Panic in 2.5.73-mm1 OOps part.

> jds wrote:
> 
> >Hi Andrew:
> >
> >
> >    I have kernel panic when boot with kernel 2.5.73-mm1, in kernel 2.5.73
> >working good.
> >
> >    Anex part the OOps: . . .
> >
> >    [< c020f503>]  kobject_register+0x23/0x60
> >    [<             blk_register_queue+0x80/0xb0
> >                   nbd_init+0x1df/0x220
> >                   do_initcalls+0x2b/0xa0
> >                   init_workqueues+0x12/0x30
> >                   init+0x28/0x150
> >                   init+0x0/0x150
> >                   kernel_thread_helper+0x50/0xc
> >. . .
> >
> I think this is my fault. I introduced a patch to nbd that 
> apparantly doesn't use the block layer quite the way the block layer 
> developers expect. As you found, it works on 2.5.73 but not in 
> 2.5.73-mm1. I'm looking into why exactly this is so I can get a fix 
> ASAP. In the meantime, if you take out the network block driver you 
> shouldn't get this oops anymore.
------- End of Original Message -------

Re: Kernel Panic in 2.5.73-mm1 OOps part.

[Lou Langholtz]

jds wrote:

>Hi Andrew:
>
>
>    I have kernel panic when boot with kernel 2.5.73-mm1, in kernel 2.5.73
>working good.
>
>    Anex part the OOps:
>
>
>    EPI: 0060:[<c20f480>]   not tainted VLI
>    EFLAHS: 0010246
>    EIP:   is at kobject_add+0xd0/0130
>    eax: 736f70a3 ebx:736f705f  ecx:00000000   edx:ffff0001
>    esi: 736f70a3 edi:dfd6653x  ebp:c157df40   esp:c157df24
>    ds:  007b  es: 007b  ss:  0068
>
>    Process:   swapper( pid:1, theaddinfo= c157c000 task = c157f880)
>    
>    Stack:
>
>    c03ed505  00000059  dfd6653c  dfd80860  dfd66400 dfd653c  c157f75c
>     
>  
>    Call Trace:
>
>    [< c020f503>]  kobject_register+0x23/0x60
>    [<             blk_register_queue+0x80/0xb0
>                   nbd_init+0x1df/0x220
>                   do_initcalls+0x2b/0xa0
>                   init_workqueues+0x12/0x30
>                   init+0x28/0x150
>                   init+0x0/0x150
>                   kernel_thread_helper+0x50/0xc
>
>   Code: feff
>   <0>Kernel Panic:  Attempted to kill init!
>. . .
>
I'm *guestimating* that the following patch will fix this problem. Let 
me know if you use it wether it makes this problem go away or not. Note 
that to me at least, blk_init_queue() should be responsible for 
initializing this memory not the driver. Either way, something has to 
initialize request_queue.kobj.kset otherwise I think this is the result 
when the kset field can be any value.

Re: Kernel Panic in 2.5.73-mm1 OOps part.

[Lou Langholtz]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

>
>
>> .. . .
>
> I'm *guestimating* that the following patch will fix this problem. Let 
> me know if you use it wether it makes this problem go away or not. 
> Note that to me at least, blk_init_queue() should be responsible for 
> initializing this memory not the driver. Either way, something has to 
> initialize request_queue.kobj.kset otherwise I think this is the 
> result when the kset field can be any value.
>
Woops... pressed send before doing the attachment...

[-- Attachment #2: patch-2.5.73-nbd --]
[-- Type: text/plain, Size: 305 bytes --]

--- drivers/block/nbd.c	2003-06-24 14:39:59.043718133 -0600
+++ drivers/block/nbd-new.c	2003-06-24 15:28:04.318158305 -0600
@@ -695,6 +695,7 @@
 			put_disk(disk);
 			goto out;
 		}
+		memset(disk->queue, 0, sizeof(struct request_queue));
 		blk_init_queue(disk->queue, do_nbd_request, &nbd_lock);
 	}
 

Re: Kernel Panic in 2.5.73-mm1 OOps part.

[jds]

  Hi Lou, Andrew:

   Ok applied the patch Lou in kernel 2.5.73-mm1, change the .config
   CONFIG_BLK_DEV_NBD=y, compile again and kernel working good not more Oops.

   In this moment testing kernel.

   Thanks again ..... :)

   Regards.




---------- Original Message -----------
From: Lou Langholtz <ldl@aros.net>
To: jds <jds@soltis.cc>
Sent: Tue, 24 Jun 2003 16:00:48 -0600
Subject: Re: Kernel Panic in 2.5.73-mm1 OOps part.

> >
> >
> >> .. . .
> >
> > I'm *guestimating* that the following patch will fix this problem. Let 
> > me know if you use it wether it makes this problem go away or not. 
> > Note that to me at least, blk_init_queue() should be responsible for 
> > initializing this memory not the driver. Either way, something has to 
> > initialize request_queue.kobj.kset otherwise I think this is the 
> > result when the kset field can be any value.
> >
> Woops... pressed send before doing the attachment...
------- End of Original Message -------