public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Dittmer <jan.dittmer@tu-harburg.de>
To: linux-net@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: pppoe, fix old protocol handler
Date: Wed, 02 Jul 2003 11:04:25 +0200	[thread overview]
Message-ID: <3F02A019.3040504@tu-harburg.de> (raw)

Hi,

I'm using 2.5(.73-mm3, but this also applies to earlier versions) and 
I'm getting tons (~6000/min) of "fix old protocol handler <pppoed>!" in 
my syslog on a quite loaded adsl line. For the time being I just 
commented out the annoying code fragment  and I didn't find any 
regressions yet (uptime ~20days).
So what's the correct way of getting rid of this message? I tried 
recompiling pppd and pppoe, but that doesn't solve it. Is there a 
patched version somewhere.

Thanks,

Jan

pppd version 2.4.2b3
Roaring Penguin PPPoE Version 3.5

--- a/net/core/dev.c    Sun Jun 15 19:11:37 2003
+++ b/net/core/dev.c    Sun Jun 15 19:11:53 2003
@@ -1370,8 +1370,8 @@
  #ifdef CONFIG_SMP
         /* Old protocols did not depened on BHs different of NET_BH and
            TIMER_BH - they need to be fixed for the new assumptions.
-        */
         print_symbol("fix old protocol handler %s!\n", (unsigned 
long)pt->func);
+        */
  #endif
         ret = pt->func(skb, skb->dev, pt);
  out:


             reply	other threads:[~2003-07-02  8:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-02  9:04 Jan Dittmer [this message]
2003-07-08  3:37 ` pppoe, fix old protocol handler David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F02A019.3040504@tu-harburg.de \
    --to=jan.dittmer@tu-harburg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox